Re: [libvirt] [PATCH v4 4/7] storage: Add support to create a luks volume

2016-07-15 Thread John Ferlan
On 07/15/2016 03:17 AM, Peter Krempa wrote: > On Thu, Jul 14, 2016 at 16:55:01 -0400, John Ferlan wrote: >> >> >> [...] >> + +void +virQEMUBuildLuksOpts(virBufferPtr buf, + virStorageEncryptionInfoDefPtr enc, + const char *alias) >>

Re: [libvirt] [PATCH v4 4/7] storage: Add support to create a luks volume

2016-07-15 Thread Peter Krempa
On Thu, Jul 14, 2016 at 16:55:01 -0400, John Ferlan wrote: > > > [...] > > >> + > >> +void > >> +virQEMUBuildLuksOpts(virBufferPtr buf, > >> + virStorageEncryptionInfoDefPtr enc, > >> + const char *alias) > >> +{ > >> +virBufferAsprintf(buf, "key-secre

Re: [libvirt] [PATCH v4 4/7] storage: Add support to create a luks volume

2016-07-14 Thread John Ferlan
[...] >> + >> +void >> +virQEMUBuildLuksOpts(virBufferPtr buf, >> + virStorageEncryptionInfoDefPtr enc, >> + const char *alias) >> +{ >> +virBufferAsprintf(buf, "key-secret=%s,", alias); >> + >> +/* If there's any cipher, then add that to the comma

Re: [libvirt] [PATCH v4 4/7] storage: Add support to create a luks volume

2016-07-14 Thread Ján Tomko
On Mon, Jul 11, 2016 at 02:07:55PM -0400, John Ferlan wrote: Partially resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1301021 If the volume xml was looking to create a luks volume take the necessary steps in order to make that happen. The processing will be: 1. create a temporary file (v

[libvirt] [PATCH v4 4/7] storage: Add support to create a luks volume

2016-07-11 Thread John Ferlan
Partially resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1301021 If the volume xml was looking to create a luks volume take the necessary steps in order to make that happen. The processing will be: 1. create a temporary file (virStorageBackendCreateQemuImgSecretPath) 1a. use the storag