Re: [libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-12-01 Thread Giuseppe Scrivano
Pavel Hrdina writes: > Well, I think that this is not correct usage of the libvirt XML. You > should not just change one part of the device configuration. If user of > virt-manager change the device type, you should create a new XML > according to the new device type and copy all valid values and

Re: [libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-12-01 Thread Pavel Hrdina
On 12/01/2014 01:50 PM, Giuseppe Scrivano wrote: Pavel Hrdina writes: The vgamem is a new attribute for QXL. The vram stil exists and its only silently updated to proper value. The configuration with vram=9216 is wrong and should be updated in virt-manager tests. the issue exists when the ty

Re: [libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-12-01 Thread Giuseppe Scrivano
Pavel Hrdina writes: > The vgamem is a new attribute for QXL. The vram stil exists and its > only silently updated to proper value. The configuration with vram=9216 > is wrong and should be updated in virt-manager tests. the issue exists when the type of an existing QXL device is changed. virt-m

Re: [libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-12-01 Thread Pavel Hrdina
On 12/01/2014 12:53 PM, Giuseppe Scrivano wrote: Pavel Hrdina writes: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6313d30..5c1b1de 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10272,6 +10272,7 @@ virDomainVideoDefParseXML(xmlNodePtr node, ch

Re: [libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-12-01 Thread Giuseppe Scrivano
Pavel Hrdina writes: > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index 6313d30..5c1b1de 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/domain_conf.c > @@ -10272,6 +10272,7 @@ virDomainVideoDefParseXML(xmlNodePtr node, > char *heads = NULL; > char *vram = NUL

Re: [libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-11-24 Thread Pavel Hrdina
On 11/24/2014 06:04 PM, Peter Krempa wrote: On 11/24/14 16:04, Pavel Hrdina wrote: Add attribute to set vgamem_mb parameter of QXL device for QEMU. This value sets the size of VGA framebuffer for QXL device. Default value in QEMU is 8MB so reuse it also in libvirt to not break things. Resolves:

Re: [libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-11-24 Thread Peter Krempa
On 11/24/14 16:04, Pavel Hrdina wrote: > Add attribute to set vgamem_mb parameter of QXL device for QEMU. This > value sets the size of VGA framebuffer for QXL device. Default value in > QEMU is 8MB so reuse it also in libvirt to not break things. > > Resolves: https://bugzilla.redhat.com/show_bug

[libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

2014-11-24 Thread Pavel Hrdina
Add attribute to set vgamem_mb parameter of QXL device for QEMU. This value sets the size of VGA framebuffer for QXL device. Default value in QEMU is 8MB so reuse it also in libvirt to not break things. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1076098 Signed-off-by: Pavel Hrdina ---