Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-24 Thread Eric Blake
On 11/24/2014 08:39 AM, Vasiliy Tolstov wrote: > 2014-11-21 11:13 GMT+03:00 Vasiliy Tolstov : >> No, in this case qemu creates device for me and all works fine. > > > If i create patch for libvirt to create tap device if user not specify > script, does it acceptable by upstream? > Benefits of thi

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-24 Thread Vasiliy Tolstov
2014-11-21 11:13 GMT+03:00 Vasiliy Tolstov : > No, in this case qemu creates device for me and all works fine. If i create patch for libvirt to create tap device if user not specify script, does it acceptable by upstream? Benefits of this patch - that we can create tap device and use it without a

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-21 Thread Vasiliy Tolstov
21 нояб. 2014 г. 9:07 пользователь "Anirban Chakraborty" написал: > > > > On 11/20/14, 5:43 AM, "Vasiliy Tolstov" wrote: > > >2014-11-20 7:58 GMT+03:00 Anirban Chakraborty : > >> Your original error message was that qemu couldn¹t find a tap device. > >>So, > >> I am not sure how the above error r

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-20 Thread Anirban Chakraborty
On 11/20/14, 5:43 AM, "Vasiliy Tolstov" wrote: >2014-11-20 7:58 GMT+03:00 Anirban Chakraborty : >> Your original error message was that qemu couldn¹t find a tap device. >>So, >> I am not sure how the above error relates to your original error. >> Can you write your detail configuration setup an

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-20 Thread Vasiliy Tolstov
2014-11-20 7:58 GMT+03:00 Anirban Chakraborty : > Your original error message was that qemu couldn¹t find a tap device. So, > I am not sure how the above error relates to your original error. > Can you write your detail configuration setup and the steps you have taken > to get at this error? If i

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-19 Thread Anirban Chakraborty
On 11/19/14, 2:05 PM, "Vasiliy Tolstov" wrote: >2014-11-19 20:54 GMT+03:00 Anirban Chakraborty : >> The patch didn¹t do anything to add/delete tap devices. Please see the >> following links where similar issue has been discussed. >> >> >>http://wiki.libvirt.org/page/Guest_won%27t_start_-_warni

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-19 Thread Vasiliy Tolstov
2014-11-19 20:54 GMT+03:00 Anirban Chakraborty : > The patch didn’t do anything to add/delete tap devices. Please see the > following links where similar issue has been discussed. > > http://wiki.libvirt.org/page/Guest_won%27t_start_-_warning:_could_not_open_ > /dev/net/tun_%28%27generic_ethernet%2

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-19 Thread Anirban Chakraborty
On 11/19/14, 9:23 AM, "Vasiliy Tolstov" wrote: >2014-11-19 20:17 GMT+03:00 Anirban Chakraborty : >> The Œethernet¹ interface type assumes that you have an existing tap >> device. Did you check if the tap device that it is complaining against >> actually exists in the host? > > >Yes, but etherne

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-19 Thread Vasiliy Tolstov
2014-11-19 20:17 GMT+03:00 Anirban Chakraborty : > The Œethernet¹ interface type assumes that you have an existing tap > device. Did you check if the tap device that it is complaining against > actually exists in the host? Yes, but ethernet device type does not always means that device already ex

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-19 Thread Anirban Chakraborty
On 11/19/14, 7:15 AM, "Vasiliy Tolstov" wrote: >2014-11-19 2:55 GMT+03:00 Anirban Chakraborty : >> Ethernet interfaces in libvirt currently do not support bandwidth >>setting. >> For example, following xml file for an interface will not apply these >> settings to corresponding qdiscs. >> >>

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-19 Thread Vasiliy Tolstov
2014-11-19 2:55 GMT+03:00 Anirban Chakraborty : > Ethernet interfaces in libvirt currently do not support bandwidth setting. > For example, following xml file for an interface will not apply these > settings to corresponding qdiscs. > > > > > > > > >

Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-19 Thread Michal Privoznik
On 19.11.2014 00:55, Anirban Chakraborty wrote: > > Ethernet interfaces in libvirt currently do not support bandwidth setting. > For example, following xml file for an interface will not apply these > settings to corresponding qdiscs. > > > > > > > >

[libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

2014-11-18 Thread Anirban Chakraborty
Ethernet interfaces in libvirt currently do not support bandwidth setting. For example, following xml file for an interface will not apply these settings to corresponding qdiscs. Signed-off-by: Anirban Chakraborty --- src/co