Re: [libvirt] [PATCH v6 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

2014-05-01 Thread Eric Blake
On 05/01/2014 03:38 AM, Daniel P. Berrange wrote: >> >> The parser already accepts repeated options (well, precisely ONE >> repeated option), by making that option be last in the command >> description and giving it .type = VSH_OT_ARGV. For comparison, see the >> echo command in virsh.c or the se

Re: [libvirt] [PATCH v6 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

2014-05-01 Thread Daniel P. Berrange
On Wed, Apr 30, 2014 at 01:44:07PM -0600, Eric Blake wrote: > On 04/30/2014 10:52 AM, Tomoki Sekiyama wrote: > > > > >> I'd think it'd be better to just allow multiple instances of > >> the arg eg > >> > >> virsh fsfreeze --mount --mount > > > > the virsh option parser rejects repeated op

Re: [libvirt] [PATCH v6 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

2014-04-30 Thread Tomoki Sekiyama
On 4/30/14 15:44 , "Eric Blake" wrote: >On 04/30/2014 10:52 AM, Tomoki Sekiyama wrote: > >> >>> I'd think it'd be better to just allow multiple instances of >>> the arg eg >>> >>> virsh fsfreeze --mount --mount >> >> the virsh option parser rejects repeated options by >> >> error: opt

Re: [libvirt] [PATCH v6 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

2014-04-30 Thread Eric Blake
On 04/30/2014 10:52 AM, Tomoki Sekiyama wrote: > >> I'd think it'd be better to just allow multiple instances of >> the arg eg >> >> virsh fsfreeze --mount --mount > > the virsh option parser rejects repeated options by > > error: option --mount already seen > > so I chose comma separ

Re: [libvirt] [PATCH v6 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

2014-04-30 Thread Tomoki Sekiyama
On 4/30/14 11:30 , "Daniel P. Berrange" wrote: >On Tue, Apr 29, 2014 at 08:04:24PM -0400, Tomoki Sekiyama wrote: >> These are exposed under domfsfreeze command and domfsthaw command. >> >> Signed-off-by: Tomoki Sekiyama >> --- >> tools/virsh-domain.c | 130 >>++

Re: [libvirt] [PATCH v6 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

2014-04-30 Thread Daniel P. Berrange
On Tue, Apr 29, 2014 at 08:04:24PM -0400, Tomoki Sekiyama wrote: > These are exposed under domfsfreeze command and domfsthaw command. > > Signed-off-by: Tomoki Sekiyama > --- > tools/virsh-domain.c | 130 > ++ > tools/virsh.pod | 23 ++

[libvirt] [PATCH v6 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

2014-04-29 Thread Tomoki Sekiyama
These are exposed under domfsfreeze command and domfsthaw command. Signed-off-by: Tomoki Sekiyama --- tools/virsh-domain.c | 130 ++ tools/virsh.pod | 23 + 2 files changed, 153 insertions(+) diff --git a/tools/virsh-domain.c b/too