Re: [libvirt] [PATCHv2] virsh: Make vshCommandOpt* report error

2014-04-14 Thread Ján Tomko
On 04/04/2014 03:50 PM, Michal Privoznik wrote: > Currently, the virsh code is plenty of the following pattern: > > if (vshCommandOptUInt(..) < 0) { > vshError(...); > goto cleanup; > } > > It doesn't make much sense to repeat the code everywhere. > Moreover, some functions from t

[libvirt] [PATCHv2] virsh: Make vshCommandOpt* report error

2014-04-04 Thread Michal Privoznik
Currently, the virsh code is plenty of the following pattern: if (vshCommandOptUInt(..) < 0) { vshError(...); goto cleanup; } It doesn't make much sense to repeat the code everywhere. Moreover, some functions from the family already report error some of them don't. Signed-off-by: