Re: [libvirt] [PATCHv2 02/13] snapshot: use new virsh function for snapshot-list

2012-06-15 Thread Eric Blake
On 06/15/2012 03:38 AM, Peter Krempa wrote: > On 06/15/12 06:18, Eric Blake wrote: >> Operating on a list of snapshot objects looks so much simpler. >> In particular, since the helper function already trimmed out >> irrelevant entries, we no longer have quite so many special cases >> on finding the

Re: [libvirt] [PATCHv2 02/13] snapshot: use new virsh function for snapshot-list

2012-06-15 Thread Peter Krempa
On 06/15/12 06:18, Eric Blake wrote: Operating on a list of snapshot objects looks so much simpler. In particular, since the helper function already trimmed out irrelevant entries, we no longer have quite so many special cases on finding the first snapshot to operate on. Also, vshTreePrint no lo

[libvirt] [PATCHv2 02/13] snapshot: use new virsh function for snapshot-list

2012-06-14 Thread Eric Blake
Operating on a list of snapshot objects looks so much simpler. In particular, since the helper function already trimmed out irrelevant entries, we no longer have quite so many special cases on finding the first snapshot to operate on. Also, vshTreePrint no longer has a generic callback struct; bot