Re: [libvirt] [PATCHv2 05/12] nodedev: add iommuGroup to node device object

2013-06-26 Thread Daniel P. Berrange
On Wed, Jun 26, 2013 at 12:53:47AM -0400, Laine Stump wrote: > I just realized that I had only implemented this for the udev nodeDevice > driver, but not the HAL driver. I can easily add the same code into the > HAL driver, but don't have any system to test building it on. > > Should I put that co

Re: [libvirt] [PATCHv2 05/12] nodedev: add iommuGroup to node device object

2013-06-25 Thread Laine Stump
I just realized that I had only implemented this for the udev nodeDevice driver, but not the HAL driver. I can easily add the same code into the HAL driver, but don't have any system to test building it on. Should I put that code in untested, or leave the HAL driver without this functionality? (Do

Re: [libvirt] [PATCHv2 05/12] nodedev: add iommuGroup to node device object

2013-06-25 Thread Daniel P. Berrange
On Mon, Jun 24, 2013 at 11:05:31PM -0400, Laine Stump wrote: > This includes adding it to the nodedev parser and formatter, docs, and > test. > --- > docs/formatnode.html.in| 63 +++- > docs/schemas/nodedev.rng | 11 +++ > src/conf/

[libvirt] [PATCHv2 05/12] nodedev: add iommuGroup to node device object

2013-06-24 Thread Laine Stump
This includes adding it to the nodedev parser and formatter, docs, and test. --- docs/formatnode.html.in| 63 +++- docs/schemas/nodedev.rng | 11 +++ src/conf/node_device_conf.c| 86 +- sr