Re: [libvirt] [PATCHv2 08/12] qemu: don't reset PCI devices being assigned with VFIO

2013-06-25 Thread Laine Stump
On 06/25/2013 01:09 PM, Daniel P. Berrange wrote: > On Tue, Jun 25, 2013 at 01:06:55PM -0400, Laine Stump wrote: >> On 06/25/2013 06:44 AM, Daniel P. Berrange wrote: >>> On Mon, Jun 24, 2013 at 11:05:34PM -0400, Laine Stump wrote: I just learned that VFIO resets PCI devices when they are assig

Re: [libvirt] [PATCHv2 08/12] qemu: don't reset PCI devices being assigned with VFIO

2013-06-25 Thread Daniel P. Berrange
On Tue, Jun 25, 2013 at 01:06:55PM -0400, Laine Stump wrote: > On 06/25/2013 06:44 AM, Daniel P. Berrange wrote: > > On Mon, Jun 24, 2013 at 11:05:34PM -0400, Laine Stump wrote: > >> I just learned that VFIO resets PCI devices when they are assigned to > >> guests / returned to the host, so it is r

Re: [libvirt] [PATCHv2 08/12] qemu: don't reset PCI devices being assigned with VFIO

2013-06-25 Thread Laine Stump
On 06/25/2013 06:44 AM, Daniel P. Berrange wrote: > On Mon, Jun 24, 2013 at 11:05:34PM -0400, Laine Stump wrote: >> I just learned that VFIO resets PCI devices when they are assigned to >> guests / returned to the host, so it is redundant for libvirt to reset >> the devices. This patch inhibits cal

Re: [libvirt] [PATCHv2 08/12] qemu: don't reset PCI devices being assigned with VFIO

2013-06-25 Thread Daniel P. Berrange
On Mon, Jun 24, 2013 at 11:05:34PM -0400, Laine Stump wrote: > I just learned that VFIO resets PCI devices when they are assigned to > guests / returned to the host, so it is redundant for libvirt to reset > the devices. This patch inhibits calling virPCIDeviceReset to devices > that will be/were a

Re: [libvirt] [PATCHv2 08/12] qemu: don't reset PCI devices being assigned with VFIO

2013-06-24 Thread Laine Stump
I didn't notice that Martin had already ACKed this patch earlier today. I just pushed it, so no further review is needed (although it would still be good to get 07/12 reviewed and pushed to be sure this patch has proper information) On 06/24/2013 11:05 PM, Laine Stump wrote: > I just learned that

[libvirt] [PATCHv2 08/12] qemu: don't reset PCI devices being assigned with VFIO

2013-06-24 Thread Laine Stump
I just learned that VFIO resets PCI devices when they are assigned to guests / returned to the host, so it is redundant for libvirt to reset the devices. This patch inhibits calling virPCIDeviceReset to devices that will be/were assigned using VFIO. --- src/qemu/qemu_hostdev.c | 4 src/qemu/q