Re: [libvirt] [PATCHv2 08/13] list: add virDomainListAllSnapshots API

2012-06-19 Thread Eric Blake
On 06/18/2012 06:22 AM, Peter Krempa wrote: > On 06/15/12 06:18, Eric Blake wrote: >> There was an inherent race between virDomainSnapshotNum() and >> virDomainSnapshotListNames(), where an additional snapshot could >> be created in the meantime, or where a snapshot could be deleted >> before conve

Re: [libvirt] [PATCHv2 08/13] list: add virDomainListAllSnapshots API

2012-06-18 Thread Peter Krempa
On 06/15/12 06:18, Eric Blake wrote: There was an inherent race between virDomainSnapshotNum() and virDomainSnapshotListNames(), where an additional snapshot could be created in the meantime, or where a snapshot could be deleted before converting the name back to a virDomainSnapshotPtr. It was a

[libvirt] [PATCHv2 08/13] list: add virDomainListAllSnapshots API

2012-06-14 Thread Eric Blake
There was an inherent race between virDomainSnapshotNum() and virDomainSnapshotListNames(), where an additional snapshot could be created in the meantime, or where a snapshot could be deleted before converting the name back to a virDomainSnapshotPtr. It was also an awkward name: the function opera