Re: [libvirt] [PATCHv2 09/11] qemu_capabilities: Persist QEMU instance over multiple QMP Cmds

2018-08-17 Thread Chris Venteicher
Quoting Jiri Denemark (2018-07-13 10:14:22) > On Mon, Jul 09, 2018 at 22:56:53 -0500, Chris Venteicher wrote: > > Commit makes starting a single persistent QEMU instance possible for use > > over multiple independent QMP commands without starting and stopping > > QEMU for each QMP command or comman

Re: [libvirt] [PATCHv2 09/11] qemu_capabilities: Persist QEMU instance over multiple QMP Cmds

2018-07-13 Thread Jiri Denemark
On Mon, Jul 09, 2018 at 22:56:53 -0500, Chris Venteicher wrote: > Commit makes starting a single persistent QEMU instance possible for use > over multiple independent QMP commands without starting and stopping > QEMU for each QMP command or command type. > > Commit allows functions outside qemu_ca

Re: [libvirt] [PATCHv2 09/11] qemu_capabilities: Persist QEMU instance over multiple QMP Cmds

2018-07-11 Thread Chris Venteicher
Quoting Collin Walling (2018-07-11 17:48:54) > I understand your approach, but I do not 100% agree with exposing the QEMU > command stuff outside of qemu_capabilities. > > In patch 10/11, you have a function defined in qemu_caps for baselining. I'd > spawn / kill your QEMU process within there. F

Re: [libvirt] [PATCHv2 09/11] qemu_capabilities: Persist QEMU instance over multiple QMP Cmds

2018-07-11 Thread Collin Walling
I understand your approach, but I do not 100% agree with exposing the QEMU command stuff outside of qemu_capabilities. In patch 10/11, you have a function defined in qemu_caps for baselining. I'd spawn / kill your QEMU process within there. For when the features flag is set (requiring you to cal

[libvirt] [PATCHv2 09/11] qemu_capabilities: Persist QEMU instance over multiple QMP Cmds

2018-07-09 Thread Chris Venteicher
Commit makes starting a single persistent QEMU instance possible for use over multiple independent QMP commands without starting and stopping QEMU for each QMP command or command type. Commit allows functions outside qemu_capabilities (ex. qemuConnectBaselineHypervisorCPU in qemu_driver) requirin