Re: [libvirt] [PATCHv2 1/3] qemu: simplify monitor fd error handling

2011-03-21 Thread Daniel P. Berrange
On Tue, Mar 15, 2011 at 08:27:16PM -0600, Eric Blake wrote: > qemu_monitor was already returning -1 and setting errno to EINVAL > on any attempt to send an fd without a unix socket, but this was > a silent failure in the case of qemuDomainAttachHostPciDevice. > Meanwhile, qemuDomainAttachNetDevice

[libvirt] [PATCHv2 1/3] qemu: simplify monitor fd error handling

2011-03-15 Thread Eric Blake
qemu_monitor was already returning -1 and setting errno to EINVAL on any attempt to send an fd without a unix socket, but this was a silent failure in the case of qemuDomainAttachHostPciDevice. Meanwhile, qemuDomainAttachNetDevice was doing some sanity checking for a better error message; it's bett