On 04/01/2014 07:34 PM, Solly Ross wrote:
I finally took time to look at this patch again. Sorry for the extreme
delay. Overall, this patch looks decent; I'll probably touch up the
findings I make below and apply it if the rest of the series is okay.
> This commit extracts the parsing logic from
This commit extracts the parsing logic from vshCommandParse
so that it can be used by other methods. The vshCommandParse
method is designed to parse full commands and error out on
unknown information, so it is not suitable to simply use it
for autocompletion. Instead, the logic has been extracted