Re: [libvirt] [PATCHv2 2/2] qemu: snapshot: Avoid libvirtd crash when qemu crashes while snapshotting

2014-01-21 Thread Peter Krempa
On 01/20/14 19:03, Eric Blake wrote: > On 01/20/2014 10:09 AM, Peter Krempa wrote: >> We shouldn't access the domain definition while we are in the monitor >> section as the domain is unlocked. Additionaly after we exit from the > > s/Additionaly/Additionally/ > >> monitor we need to check if the

Re: [libvirt] [PATCHv2 2/2] qemu: snapshot: Avoid libvirtd crash when qemu crashes while snapshotting

2014-01-21 Thread Ján Tomko
On 01/20/2014 06:09 PM, Peter Krempa wrote: > We shouldn't access the domain definition while we are in the monitor > section as the domain is unlocked. Additionaly after we exit from the > monitor we need to check if the VM is still alive. Not doing so resulted > into crash if qemu exits while att

Re: [libvirt] [PATCHv2 2/2] qemu: snapshot: Avoid libvirtd crash when qemu crashes while snapshotting

2014-01-20 Thread Martin Kletzander
On Mon, Jan 20, 2014 at 06:09:33PM +0100, Peter Krempa wrote: > We shouldn't access the domain definition while we are in the monitor > section as the domain is unlocked. Additionaly after we exit from the > monitor we need to check if the VM is still alive. Not doing so resulted > into crash if qe

Re: [libvirt] [PATCHv2 2/2] qemu: snapshot: Avoid libvirtd crash when qemu crashes while snapshotting

2014-01-20 Thread Eric Blake
On 01/20/2014 10:09 AM, Peter Krempa wrote: > We shouldn't access the domain definition while we are in the monitor > section as the domain is unlocked. Additionaly after we exit from the s/Additionaly/Additionally/ > monitor we need to check if the VM is still alive. Not doing so resulted > into

[libvirt] [PATCHv2 2/2] qemu: snapshot: Avoid libvirtd crash when qemu crashes while snapshotting

2014-01-20 Thread Peter Krempa
We shouldn't access the domain definition while we are in the monitor section as the domain is unlocked. Additionaly after we exit from the monitor we need to check if the VM is still alive. Not doing so resulted into crash if qemu exits while attempting to do a external VM snapshot. --- Notes: