Re: [libvirt] [PATCHv2 4/6] API: Introduce VIR_DOMAIN_VCPU_AGENT, for agent based CPU hot(un)plug

2013-04-23 Thread Eric Blake
On 04/23/2013 09:52 AM, Daniel P. Berrange wrote: >> Any other design or naming suggestions are welcome. > > Since 'cpu_id' in this refers to the guest OS' notion of CPUs, > do we need some way to expose what the guest OS considers the > CPU IDs to be. Qemu is still working on that point. For 1.

Re: [libvirt] [PATCHv2 4/6] API: Introduce VIR_DOMAIN_VCPU_AGENT, for agent based CPU hot(un)plug

2013-04-23 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 12:00:09PM +0200, Peter Krempa wrote: > Hmm, okay that seems fair enough. The virDomainSetvcpus api has the > ideal name for this but mixing the semantics of disabling CPUs with > the angent and ripping them out from the hypervisor might lead to > user confusion. > > In thi

Re: [libvirt] [PATCHv2 4/6] API: Introduce VIR_DOMAIN_VCPU_AGENT, for agent based CPU hot(un)plug

2013-04-18 Thread Peter Krempa
On 04/17/13 11:16, Daniel P. Berrange wrote: On Wed, Apr 17, 2013 at 08:47:01AM +0200, Peter Krempa wrote: On 04/16/13 19:41, Daniel P. Berrange wrote: On Tue, Apr 16, 2013 at 04:00:10PM +0200, Peter Krempa wrote: This flag will allow to use qemu guest agent commands to disable (offline) and e

Re: [libvirt] [PATCHv2 4/6] API: Introduce VIR_DOMAIN_VCPU_AGENT, for agent based CPU hot(un)plug

2013-04-17 Thread Daniel P. Berrange
On Wed, Apr 17, 2013 at 08:47:01AM +0200, Peter Krempa wrote: > On 04/16/13 19:41, Daniel P. Berrange wrote: > >On Tue, Apr 16, 2013 at 04:00:10PM +0200, Peter Krempa wrote: > >>This flag will allow to use qemu guest agent commands to disable > >>(offline) and enable (online) processors in a live g

Re: [libvirt] [PATCHv2 4/6] API: Introduce VIR_DOMAIN_VCPU_AGENT, for agent based CPU hot(un)plug

2013-04-16 Thread Peter Krempa
On 04/16/13 19:41, Daniel P. Berrange wrote: On Tue, Apr 16, 2013 at 04:00:10PM +0200, Peter Krempa wrote: This flag will allow to use qemu guest agent commands to disable (offline) and enable (online) processors in a live guest that has the guest agent running. How do guest CPU offline/online

Re: [libvirt] [PATCHv2 4/6] API: Introduce VIR_DOMAIN_VCPU_AGENT, for agent based CPU hot(un)plug

2013-04-16 Thread Daniel P. Berrange
On Tue, Apr 16, 2013 at 04:00:10PM +0200, Peter Krempa wrote: > This flag will allow to use qemu guest agent commands to disable > (offline) and enable (online) processors in a live guest that has the > guest agent running. How do guest CPU offline/online state changes relate to the offline/online

[libvirt] [PATCHv2 4/6] API: Introduce VIR_DOMAIN_VCPU_AGENT, for agent based CPU hot(un)plug

2013-04-16 Thread Peter Krempa
This flag will allow to use qemu guest agent commands to disable (offline) and enable (online) processors in a live guest that has the guest agent running. --- Notes: Version 2: - improve api docs - reject _MAXIMUM and _AGENT to the setter func - break long line include/libvirt/l