Re: [libvirt] [PATCHv3 06/10] storage: simplify fd handling

2011-03-04 Thread Eric Blake
On 03/04/2011 01:15 AM, Paolo Bonzini wrote: > On 03/04/2011 01:37 AM, Eric Blake wrote: >> - unsigned int flags ATTRIBUTE_UNUSED) >> + unsigned int flags) > > Uhm, you're still not using the flags, you're just using the argument as > a place to

Re: [libvirt] [PATCHv3 06/10] storage: simplify fd handling

2011-03-04 Thread Paolo Bonzini
On 03/04/2011 01:37 AM, Eric Blake wrote: - unsigned int flags ATTRIBUTE_UNUSED) + unsigned int flags) Uhm, you're still not using the flags, you're just using the argument as a place to write the flags for virFileOperation. Perhaps the "inn

[libvirt] [PATCHv3 06/10] storage: simplify fd handling

2011-03-03 Thread Eric Blake
* src/storage/storage_backend.c (virStorageBackendCreateRaw): Use new virFileOperation flag. --- v3: new patch; unrelated, but the only other client of virFileOperation src/storage/storage_backend.c | 47 +--- 1 files changed, 29 insertions(+), 18 deletions(