Re: [libvirt] [PATCHv3 1/4] nodeinfo: enable nodeGetCPUCount for older kernels

2012-11-15 Thread Viktor Mihajlovski
On 11/15/2012 04:43 AM, Eric Blake wrote: The assumption here is that any kernel lacking cpu/present also lacks hotplug, and therefore the cpuNN will be consecutive and we aren't going to miss anything. You removed that assumption from the comment, but I think it is important to leave in. ACK.

Re: [libvirt] [PATCHv3 1/4] nodeinfo: enable nodeGetCPUCount for older kernels

2012-11-14 Thread Eric Blake
On 11/13/2012 05:54 AM, Viktor Mihajlovski wrote: > Since /sys/devices/system/cpu/present is not available on > older kernels like on RHEL 5.x nodeGetCPUCount will > fail there. The fallback implemented is to scan for > /sys/devices/system/cpu/cpuNN entries. > > Signed-off-by: Viktor Mihajlovski

[libvirt] [PATCHv3 1/4] nodeinfo: enable nodeGetCPUCount for older kernels

2012-11-13 Thread Viktor Mihajlovski
Since /sys/devices/system/cpu/present is not available on older kernels like on RHEL 5.x nodeGetCPUCount will fail there. The fallback implemented is to scan for /sys/devices/system/cpu/cpuNN entries. Signed-off-by: Viktor Mihajlovski --- src/nodeinfo.c | 33 - 1