Re: [libvirt] [PATCHv4 24/51] snapshot: prevent stranding snapshot data on domain destruction

2012-11-05 Thread Philipp Hahn
Hello Eric, thank you for your answer; I had hoped to stop your from spending any further time ony this by my 2nd mail from October 26, because I found my thinko myself after reading some more code. Actually I was reading a patched version, where the patch broke it. > > This behaviour is actua

Re: [libvirt] [PATCHv4 24/51] snapshot: prevent stranding snapshot data on domain destruction

2012-10-30 Thread Eric Blake
On 10/26/2012 09:47 AM, Philipp Hahn wrote: > Hello Eric, > > On Friday 02 September 2011 06:25:01 Eric Blake wrote: >> Just as leaving managed save metadata behind can cause problems >> when creating a new domain that happens to collide with the name >> of the just-deleted domain, the same is tru

Re: [libvirt] [PATCHv4 24/51] snapshot: prevent stranding snapshot data on domain destruction

2012-10-26 Thread Philipp Hahn
Hello Eoric, Forget my previous mail, that was a patched version. qemuDomainRemoveInactive() is deleting the snapshots, but still: I would prefer to check for snapshots to extend for inactive domains as well. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@u

Re: [libvirt] [PATCHv4 24/51] snapshot: prevent stranding snapshot data on domain destruction

2012-10-26 Thread Philipp Hahn
Hello Eric, On Friday 02 September 2011 06:25:01 Eric Blake wrote: > Just as leaving managed save metadata behind can cause problems > when creating a new domain that happens to collide with the name > of the just-deleted domain, the same is true of leaving any > snapshot metadata behind. I just

[libvirt] [PATCHv4 24/51] snapshot: prevent stranding snapshot data on domain destruction

2011-09-01 Thread Eric Blake
Just as leaving managed save metadata behind can cause problems when creating a new domain that happens to collide with the name of the just-deleted domain, the same is true of leaving any snapshot metadata behind. For safety sake, extend the semantic change of commit b26a9fa9 to also cover snapsh