Re: [libvirt] [PATCHv4 3/4]vbox: Use vboxUniformedAPI to write common code

2014-07-02 Thread Michal Privoznik
On 02.07.2014 15:45, Taowei Luo wrote: 2014-07-02 17:12 GMT+08:00 Michal Privoznik mailto:mpriv...@redhat.com>>: On 26.06.2014 15 :51, Taowei wrote: In vbox_common.c: vboxInitialize and vboxDomainSave are rewrited with vboxUniformedAPI. In vbox_common.h

Re: [libvirt] [PATCHv4 3/4]vbox: Use vboxUniformedAPI to write common code

2014-07-02 Thread Taowei Luo
2014-07-02 17:12 GMT+08:00 Michal Privoznik : > On 26.06.2014 15:51, Taowei wrote: > >> In vbox_common.c: >> vboxInitialize and vboxDomainSave are rewrited with vboxUniformedAPI. >> >> In vbox_common.h >> Some common definitions in vbox_CAPI_v*.h are directly extracted to >> this file. Some other

Re: [libvirt] [PATCHv4 3/4]vbox: Use vboxUniformedAPI to write common code

2014-07-02 Thread Taowei Luo
The most code in vbox_common.h is extracted from the vbox_CAPI_v*.h.​ I know some symbols like PR_INT16_MAX or PR_INT16_MIN may not be necessary, as well as the definition of the NS_LIKELY and NS_UNLIKEY. But I put it here because I treat these codes as a whole thing and not separate them. I think

Re: [libvirt] [PATCHv4 3/4]vbox: Use vboxUniformedAPI to write common code

2014-07-02 Thread Michal Privoznik
On 26.06.2014 15:51, Taowei wrote: In vbox_common.c: vboxInitialize and vboxDomainSave are rewrited with vboxUniformedAPI. In vbox_common.h Some common definitions in vbox_CAPI_v*.h are directly extracted to this file. Some other incompatible defintions are simplified here. So we can write commo

[libvirt] [PATCHv4 3/4]vbox: Use vboxUniformedAPI to write common code

2014-06-26 Thread Taowei
In vbox_common.c: vboxInitialize and vboxDomainSave are rewrited with vboxUniformedAPI. In vbox_common.h Some common definitions in vbox_CAPI_v*.h are directly extracted to this file. Some other incompatible defintions are simplified here. So we can write common code with it. --- po/POTFILES.in