Re: [libvirt] [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate

2013-11-26 Thread Eric Blake
On 11/26/2013 08:23 AM, Amos Kong wrote: >> >> Hmm. Libvirt is already converting a user's rate of bytes/period into >> the qemu parameters, defaulting to 1 second as its default period. > > So libvirt will always pass a fixed 1 second period to qemu? You forced me to check the code :) We're s

Re: [libvirt] [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate

2013-11-26 Thread Amos Kong
On Tue, Nov 26, 2013 at 07:32:37AM -0700, Eric Blake wrote: > [adding libvirt] > > On 11/26/2013 06:58 AM, Paolo Bonzini wrote: > > Il 26/11/2013 14:43, Amos Kong ha scritto: > >> /* Set a default rate limit of 2^47 bytes per minute or roughly 2TB/s. If > >> * you have an entropy source capable

Re: [libvirt] [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate

2013-11-26 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 26/11/2013 15:32, Eric Blake ha scritto: > Hmm. Libvirt is already converting a user's rate of bytes/period > into the qemu parameters, defaulting to 1 second as its default > period. Am I correct that as long as libvirt specified both rate > AND

Re: [libvirt] [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate

2013-11-26 Thread Eric Blake
[adding libvirt] On 11/26/2013 06:58 AM, Paolo Bonzini wrote: > Il 26/11/2013 14:43, Amos Kong ha scritto: >> /* Set a default rate limit of 2^47 bytes per minute or roughly 2TB/s. If >> * you have an entropy source capable of generating more entropy than this >> * and you can pass it through v