Re: [libvirt] [Qemu-devel] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-03 Thread Daniel P. Berrange
On Fri, May 03, 2013 at 08:52:59AM -0500, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote: > >> Kevin Wolf writes: > >> >> >> + > >> >> >> +if (strcmp(type, "ide-cd") == 0) { > >> >> >> +disk_type = D

Re: [libvirt] [Qemu-devel] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-03 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote: >> Kevin Wolf writes: >> >> >> + >> >> >> +if (strcmp(type, "ide-cd") == 0) { >> >> >> +disk_type = DT_CDROM; >> >> >> +} else if (strcmp(type, "isa-fdc") == 0) { >> >> >>

Re: [libvirt] [Qemu-devel] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-03 Thread Daniel P. Berrange
On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote: > Kevin Wolf writes: > >> >> + > >> >> +if (strcmp(type, "ide-cd") == 0) { > >> >> +disk_type = DT_CDROM; > >> >> +} else if (strcmp(type, "isa-fdc") == 0) { > >> >> +disk_type = DT_FLOPPY; > >

Re: [libvirt] [Qemu-devel] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-02 Thread Anthony Liguori
Kevin Wolf writes: > Am 02.05.2013 um 15:41 hat Anthony Liguori geschrieben: >> Kevin Wolf writes: >> >> > >> > Ugh. Comparing the device name to an incomplete set of strings here and >> > then figuring out for each what the specific way for this device is to >> > create a nice string sounds li