Re: [libvirt] [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-03 Thread Eric Blake
On 05/03/2013 08:58 AM, Andreas Färber wrote: > >> I agree that libvirt would very much like to have this in 1.5. How >> can I help in reviewing things? > > Apart from the usual QMP considerations that you will know much better > than me, I have two concerns here: > 1) Polluting the QOM namespac

Re: [libvirt] [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-03 Thread Igor Mammedov
On Fri, 03 May 2013 16:58:44 +0200 Andreas Färber wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 02.05.2013 21:48, schrieb Eric Blake: > > On 05/02/2013 01:43 PM, Eduardo Habkost wrote: > >>> > >>> As mentioned earlier I'd prefer to defer the property design > >>> rather than p

Re: [libvirt] [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-03 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 02.05.2013 21:48, schrieb Eric Blake: > On 05/02/2013 01:43 PM, Eduardo Habkost wrote: >>> >>> As mentioned earlier I'd prefer to defer the property design >>> rather than putting it lightly reviewed into 1.5 and living >>> with some ABI. If libvir

Re: [libvirt] [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-02 Thread Eric Blake
On 05/02/2013 01:43 PM, Eduardo Habkost wrote: >> >> As mentioned earlier I'd prefer to defer the property design rather than >> putting it lightly reviewed into 1.5 and living with some ABI. >> If libvirt urgently needs this info, this series needs to be reviewed >> and sorted out until the weeken

Re: [libvirt] [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-02 Thread Eduardo Habkost
On Thu, May 02, 2013 at 12:53:33AM +0200, Andreas Färber wrote: > > Eduardo Habkost (9): > > target-i386: cleanup: Group together level, xlevel, xlevel2 fields > > target-i386/kvm.c: Code formatting changes > > target-i386/cpu.c: Break lines so they don't get too long > > target-i386: Repla

Re: [libvirt] [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-01 Thread Andreas Färber
Am 22.04.2013 21:00, schrieb Eduardo Habkost: > This series includes the previous "replace cpuid_*features fields with a > feature > word array" series. > > The first 4 patches already have a Reviewed-by from Igor, they correspond to > v10 > plus a small indent fix requested by him. > > As the