Re: [libvirt] [Qemu-devel] [PATCH v2] qmp: access the local QemuOptsLists for drive option

2013-11-08 Thread Fam Zheng
On 11/09/2013 11:19 AM, Amos Kong wrote: On Fri, Nov 08, 2013 at 05:18:02PM +0800, Fam Zheng wrote: Looks good to me. Two small comments below. On Wed, 11/06 13:16, Amos Kong wrote: Currently we have three QemuOptsList (qemu_common_drive_opts, qemu_legacy_drive_opts, and qemu_drive_opts), only

Re: [libvirt] [Qemu-devel] [PATCH v2] qmp: access the local QemuOptsLists for drive option

2013-11-08 Thread Amos Kong
On Fri, Nov 08, 2013 at 05:18:02PM +0800, Fam Zheng wrote: > Looks good to me. Two small comments below. > > On Wed, 11/06 13:16, Amos Kong wrote: > > Currently we have three QemuOptsList (qemu_common_drive_opts, > > qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts > > is added t

Re: [libvirt] [Qemu-devel] [PATCH v2] qmp: access the local QemuOptsLists for drive option

2013-11-08 Thread Fam Zheng
Looks good to me. Two small comments below. On Wed, 11/06 13:16, Amos Kong wrote: > Currently we have three QemuOptsList (qemu_common_drive_opts, > qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts > is added to vm_config_groups[]. > > This patch changes query-command-line-option