Re: [libvirt] [RFC] [PATCH 1/3 v3] vepa+vsi: Introduce dependency on libnl

2010-05-25 Thread Stefan Berger
On Tue, 2010-05-25 at 14:53 -0400, Laine Stump wrote: > On 05/25/2010 02:34 PM, Stefan Berger wrote: > > On Tue, 2010-05-25 at 11:58 -0600, Eric Blake wrote: > > > >> On 05/24/2010 06:24 AM, Stefan Berger wrote: > >> > >>> @@ -283,6 +289,10 @@ BuildRequires: yajl-devel > >>> %if %{with_

Re: [libvirt] [RFC] [PATCH 1/3 v3] vepa+vsi: Introduce dependency on libnl

2010-05-25 Thread Laine Stump
On 05/25/2010 02:34 PM, Stefan Berger wrote: On Tue, 2010-05-25 at 11:58 -0600, Eric Blake wrote: On 05/24/2010 06:24 AM, Stefan Berger wrote: @@ -283,6 +289,10 @@ BuildRequires: yajl-devel %if %{with_libpcap} BuildRequires: libpcap-devel %endif +%if %{with_libnl} +BuildRequires

Re: [libvirt] [RFC] [PATCH 1/3 v3] vepa+vsi: Introduce dependency on libnl

2010-05-25 Thread Stefan Berger
On Tue, 2010-05-25 at 11:58 -0600, Eric Blake wrote: > On 05/24/2010 06:24 AM, Stefan Berger wrote: > > @@ -283,6 +289,10 @@ BuildRequires: yajl-devel > > %if %{with_libpcap} > > BuildRequires: libpcap-devel > > %endif > > +%if %{with_libnl} > > +BuildRequires: libnl-devel > > +Requires: libnl >

Re: [libvirt] [RFC] [PATCH 1/3 v3] vepa+vsi: Introduce dependency on libnl

2010-05-25 Thread Eric Blake
On 05/24/2010 06:24 AM, Stefan Berger wrote: > @@ -283,6 +289,10 @@ BuildRequires: yajl-devel > %if %{with_libpcap} > BuildRequires: libpcap-devel > %endif > +%if %{with_libnl} > +BuildRequires: libnl-devel > +Requires: libnl > +%endif Correction - it was pointed out to me on IRC that the 'Requ

Re: [libvirt] [RFC] [PATCH 1/3 v3] vepa+vsi: Introduce dependency on libnl

2010-05-25 Thread Eric Blake
On 05/24/2010 06:24 AM, Stefan Berger wrote: > This patch introduces a dependency on libnl, which subsequent patches > will then use. I'm hoping that this is the correct version to be reviewing - but since it looks like the vepa patches depend on this one, we need to push this one through :) > --

[libvirt] [RFC] [PATCH 1/3 v3] vepa+vsi: Introduce dependency on libnl

2010-05-24 Thread Stefan Berger
This patch introduces a dependency on libnl, which subsequent patches will then use. Changes from V2 to V3: - Added requirement for libnl during runtime (Requires: libnl) Changes from V1 to V2: - added diffstats - following changes in tree Signed-off-by: Stefan Berger --- configure.ac|