Re: [libvirt] [RFC PATCH 1/6] util: Add API for converting virBitmap into printable string

2011-02-10 Thread Jiri Denemark
> > +for ( ; sz > 0; sz--) > > +virBufferVSprintf(&buf, "%08x", bitmap->map[sz - 1]); > > I probably would have written: > > while (sz--) > virBufferVSprintf(&buf, "%08x", bitmap->map[sz]); Yeah, it looks nicer; I'll use that since I'll send a new version anyway. > since sz is g

Re: [libvirt] [RFC PATCH 1/6] util: Add API for converting virBitmap into printable string

2011-02-09 Thread Eric Blake
On 02/09/2011 09:01 AM, Jiri Denemark wrote: > --- > src/libvirt_private.syms |1 + > src/util/bitmap.c| 32 +++- > src/util/bitmap.h|3 +++ > 3 files changed, 35 insertions(+), 1 deletions(-) > +char *virBitmapString(virBitmapPtr bitmap) > +{

[libvirt] [RFC PATCH 1/6] util: Add API for converting virBitmap into printable string

2011-02-09 Thread Jiri Denemark
--- src/libvirt_private.syms |1 + src/util/bitmap.c| 32 +++- src/util/bitmap.h|3 +++ 3 files changed, 35 insertions(+), 1 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index b9e3efe..335d12f 100644 --- a/src/