Re: [libvirt] [RFC PATCH 3/5] qemu: driver: Remove support for native->XML conversion

2019-06-17 Thread Peter Krempa
On Fri, Jun 14, 2019 at 15:51:31 +0200, Ján Tomko wrote: > On Fri, Jun 14, 2019 at 03:30:25PM +0200, Peter Krempa wrote: > > This code is really neglected and does not at all work reliably. It > > can't even be used for converting our own commandline back. > > > > Since this was mostly useful for

Re: [libvirt] [RFC PATCH 3/5] qemu: driver: Remove support for native->XML conversion

2019-06-14 Thread Andrea Bolognani
On Fri, 2019-06-14 at 15:30 +0200, Peter Krempa wrote: [...] > +virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", > + _("qemu driver no longer supports native to XML > conversion")); "Converting arbitrary QEMU command lines to libvirt domain XML is no longer supported". -

Re: [libvirt] [RFC PATCH 3/5] qemu: driver: Remove support for native->XML conversion

2019-06-14 Thread Ján Tomko
On Fri, Jun 14, 2019 at 03:30:25PM +0200, Peter Krempa wrote: This code is really neglected and does not at all work reliably. It can't even be used for converting our own commandline back. Since this was mostly useful for aiding migration from manually run qemu to libvirt and will not work for

[libvirt] [RFC PATCH 3/5] qemu: driver: Remove support for native->XML conversion

2019-06-14 Thread Peter Krempa
This code is really neglected and does not at all work reliably. It can't even be used for converting our own commandline back. Since this was mostly useful for aiding migration from manually run qemu to libvirt and will not work for this puspose in many cases it's not worth having in my opinion.