Re: [libvirt] [dbus PATCH] tests: fix test_connect

2019-04-16 Thread Pavel Hrdina
On Tue, Apr 16, 2019 at 12:44:26AM +0200, Ján Tomko wrote: > On Mon, Apr 15, 2019 at 02:15:28PM -0400, Cole Robinson wrote: > > On 4/15/19 11:25 AM, Pavel Hrdina wrote: > > > Calling fixtures directly was removed in pytest 4.0, we can change the > > > fixture to be a wrapper around the original fun

Re: [libvirt] [dbus PATCH] tests: fix test_connect

2019-04-15 Thread Ján Tomko
On Mon, Apr 15, 2019 at 02:15:28PM -0400, Cole Robinson wrote: On 4/15/19 11:25 AM, Pavel Hrdina wrote: Calling fixtures directly was removed in pytest 4.0, we can change the fixture to be a wrapper around the original function and use the original fixture name. Would be nice to call out the d

Re: [libvirt] [dbus PATCH] tests: fix test_connect

2019-04-15 Thread Cole Robinson
On 4/15/19 11:25 AM, Pavel Hrdina wrote: > Calling fixtures directly was removed in pytest 4.0, we can change the > fixture to be a wrapper around the original function and use the > original fixture name. > > Signed-off-by: Pavel Hrdina > --- > tests/libvirttest.py | 15 +-- > 1 fil

[libvirt] [dbus PATCH] tests: fix test_connect

2019-04-15 Thread Pavel Hrdina
Calling fixtures directly was removed in pytest 4.0, we can change the fixture to be a wrapper around the original function and use the original fixture name. Signed-off-by: Pavel Hrdina --- tests/libvirttest.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/