Re: [libvirt] [glib 3/5] gconfig: Create objects for all domain device nodes

2016-11-03 Thread Zeeshan Ali
On Thu, Nov 3, 2016 at 12:34 PM, Christophe Fergeau wrote: > On Thu, Nov 03, 2016 at 10:00:56AM +0100, Zeeshan Ali wrote: >> Hi Christophe, >> >> On Wed, Nov 2, 2016 at 6:21 PM, Christophe Fergeau >> wrote: >> > Hey, >> > >> > On Tue, Nov 01, 2016 at 05:46:05PM +0100, Zeeshan Ali wrote: >> >> Cu

Re: [libvirt] [glib 3/5] gconfig: Create objects for all domain device nodes

2016-11-03 Thread Christophe Fergeau
On Thu, Nov 03, 2016 at 10:00:56AM +0100, Zeeshan Ali wrote: > Hi Christophe, > > On Wed, Nov 2, 2016 at 6:21 PM, Christophe Fergeau > wrote: > > Hey, > > > > On Tue, Nov 01, 2016 at 05:46:05PM +0100, Zeeshan Ali wrote: > >> Currently we can and do get into serious trouble with this kind of code

Re: [libvirt] [glib 3/5] gconfig: Create objects for all domain device nodes

2016-11-03 Thread Zeeshan Ali
Hi Christophe, On Wed, Nov 2, 2016 at 6:21 PM, Christophe Fergeau wrote: > Hey, > > On Tue, Nov 01, 2016 at 05:46:05PM +0100, Zeeshan Ali wrote: >> Currently we can and do get into serious trouble with this kind of code: >> >> devices = gvir_config_domain_get_devices(domain); >> gvir_config_domai

Re: [libvirt] [glib 3/5] gconfig: Create objects for all domain device nodes

2016-11-02 Thread Christophe Fergeau
Hey, On Tue, Nov 01, 2016 at 05:46:05PM +0100, Zeeshan Ali wrote: > Currently we can and do get into serious trouble with this kind of code: > > devices = gvir_config_domain_get_devices(domain); > gvir_config_domain_set_devices(domain, domain); > > since the first call above won't return a compl

Re: [libvirt] [glib 3/5] gconfig: Create objects for all domain device nodes

2016-11-02 Thread Daniel P. Berrange
On Tue, Nov 01, 2016 at 05:46:05PM +0100, Zeeshan Ali wrote: > Currently we can and do get into serious trouble with this kind of code: > > devices = gvir_config_domain_get_devices(domain); > gvir_config_domain_set_devices(domain, domain); > > since the first call above won't return a complete li

[libvirt] [glib 3/5] gconfig: Create objects for all domain device nodes

2016-11-01 Thread Zeeshan Ali
Currently we can and do get into serious trouble with this kind of code: devices = gvir_config_domain_get_devices(domain); gvir_config_domain_set_devices(domain, domain); since the first call above won't return a complete list of objects present in the domain but only the ones we have specific cl