Re: [libvirt] [go PATCH] Add support for virNetworkPort object and APIs

2019-06-19 Thread Daniel P . Berrangé
On Tue, Jun 18, 2019 at 04:43:35PM +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > network.go | 80 ++ > network_port.go | 233 > network_port_compat.h | 67 > network_port_wrap

Re: [libvirt] [go PATCH] Add support for virNetworkPort object and APIs

2019-06-19 Thread Christophe de Dinechin
> On 19 Jun 2019, at 11:14, Daniel P. Berrangé wrote: > > On Wed, Jun 19, 2019 at 10:50:14AM +0200, Christophe de Dinechin wrote: > > So the first thing our Go code does is check the libvirt native library > version number and report an error > > eg > > func (n *NetworkPort) Delete(flags ui

Re: [libvirt] [go PATCH] Add support for virNetworkPort object and APIs

2019-06-19 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 10:50:14AM +0200, Christophe de Dinechin wrote: > > > > On 18 Jun 2019, at 19:01, Daniel P. Berrangé wrote: > > > > On Tue, Jun 18, 2019 at 06:33:01PM +0200, Christophe de Dinechin wrote: > >> > >> > >>> On 18 Jun 2019, at 17:43, Daniel P. Berrangé wrote: > >>> > >>>

Re: [libvirt] [go PATCH] Add support for virNetworkPort object and APIs

2019-06-19 Thread Christophe de Dinechin
> On 18 Jun 2019, at 19:01, Daniel P. Berrangé wrote: > > On Tue, Jun 18, 2019 at 06:33:01PM +0200, Christophe de Dinechin wrote: >> >> >>> On 18 Jun 2019, at 17:43, Daniel P. Berrangé wrote: >>> >>> Signed-off-by: Daniel P. Berrangé >>> --- >>> network.go | 80 ++

Re: [libvirt] [go PATCH] Add support for virNetworkPort object and APIs

2019-06-18 Thread Daniel P . Berrangé
On Tue, Jun 18, 2019 at 06:33:01PM +0200, Christophe de Dinechin wrote: > > > > On 18 Jun 2019, at 17:43, Daniel P. Berrangé wrote: > > > > Signed-off-by: Daniel P. Berrangé > > --- > > network.go | 80 ++ > > network_port.go | 233 +

Re: [libvirt] [go PATCH] Add support for virNetworkPort object and APIs

2019-06-18 Thread Christophe de Dinechin
> On 18 Jun 2019, at 17:43, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > --- > network.go | 80 ++ > network_port.go | 233 > network_port_compat.h | 67 > network_port_wrapper.go | 197

[libvirt] [go PATCH] Add support for virNetworkPort object and APIs

2019-06-18 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- network.go | 80 ++ network_port.go | 233 network_port_compat.h | 67 network_port_wrapper.go | 197 + network_port_wrapper.h | 79 ++