Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2011 at 03:21:54PM +0200, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > libvirt-gobject/libvirt-gobject-storage-vol.c | 25 > + > libvirt-gobject/libvirt-gobject-storage-vol.h |4 > libvirt-gobject/libvirt-gobject.sym

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-05 Thread Zeeshan Ali (Khattak)
On Mon, Dec 5, 2011 at 1:10 PM, Christophe Fergeau wrote: > This is exactly the same patch as the one you sent before isn't it? What > about the g_set_error VS gvir_error_new concerns? How do we handle this? Oops! Forgot to commit. :( -- Regards, Zeeshan Ali (Khattak) FSF member#5124 -- li

[libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-05 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" --- libvirt-gobject/libvirt-gobject-storage-vol.c | 25 + libvirt-gobject/libvirt-gobject-storage-vol.h |4 libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 30 insertions(+), 0 deletions(-) diff --git a/lib

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-05 Thread Daniel P. Berrange
On Sat, Dec 03, 2011 at 12:11:04AM +0200, Zeeshan Ali (Khattak) wrote: > On Fri, Dec 2, 2011 at 6:34 PM, Christophe Fergeau > wrote: > > On Fri, Dec 02, 2011 at 05:34:15PM +0200, Zeeshan Ali (Khattak) wrote: > >> From: "Zeeshan Ali (Khattak)" > >> > >> +    if (virStorageVolDelete(vol->priv->han

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-05 Thread Christophe Fergeau
This is exactly the same patch as the one you sent before isn't it? What about the g_set_error VS gvir_error_new concerns? How do we handle this? Christophe On Sat, Dec 03, 2011 at 01:44:48AM +0200, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > libvirt-gobject/libvirt-

[libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-02 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" --- libvirt-gobject/libvirt-gobject-storage-vol.c | 25 + libvirt-gobject/libvirt-gobject-storage-vol.h |4 libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 30 insertions(+), 0 deletions(-) diff --git a/lib

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-02 Thread Christophe Fergeau
On Sat, Dec 03, 2011 at 12:11:04AM +0200, Zeeshan Ali (Khattak) wrote: > On Fri, Dec 2, 2011 at 6:34 PM, Christophe Fergeau > wrote: > > On Fri, Dec 02, 2011 at 05:34:15PM +0200, Zeeshan Ali (Khattak) wrote: > >> From: "Zeeshan Ali (Khattak)" > >> > >> +    if (virStorageVolDelete(vol->priv->han

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-02 Thread Zeeshan Ali (Khattak)
On Fri, Dec 2, 2011 at 6:34 PM, Christophe Fergeau wrote: > On Fri, Dec 02, 2011 at 05:34:15PM +0200, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" >> >> +    if (virStorageVolDelete(vol->priv->handle, flags) < 0) { >> +        g_set_error (err, >> +                     GVIR_STORA

Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-02 Thread Christophe Fergeau
On Fri, Dec 02, 2011 at 05:34:15PM +0200, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > libvirt-gobject/libvirt-gobject-storage-vol.c | 25 > + > libvirt-gobject/libvirt-gobject-storage-vol.h |4 > libvirt-gobject/libvirt-gobject.sym

[libvirt] [libvirt-glib] Add wrapper for volume deletion API

2011-12-02 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" --- libvirt-gobject/libvirt-gobject-storage-vol.c | 25 + libvirt-gobject/libvirt-gobject-storage-vol.h |4 libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 30 insertions(+), 0 deletions(-) diff --git a/lib