Re: [libvirt] [libvirt-go PATCH 2/2] Introduce DomainMigrateMaxSpeedFlags constant

2019-02-11 Thread Erik Skultety
On Mon, Feb 11, 2019 at 03:23:31PM +, Daniel P. Berrangé wrote: > On Mon, Feb 11, 2019 at 04:11:55PM +0100, Erik Skultety wrote: > > Also enforce the enum type for MigrateSetMaxSpeed and MigrateGetMaxSpeed > > functions which previously accepted generic uint32 type since the flags > > haven't b

Re: [libvirt] [libvirt-go PATCH 2/2] Introduce DomainMigrateMaxSpeedFlags constant

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 04:11:55PM +0100, Erik Skultety wrote: > Also enforce the enum type for MigrateSetMaxSpeed and MigrateGetMaxSpeed > functions which previously accepted generic uint32 type since the flags > haven't been in use. FWIW, Erik asked me about this change off-list. Technically ch

[libvirt] [libvirt-go PATCH 2/2] Introduce DomainMigrateMaxSpeedFlags constant

2019-02-11 Thread Erik Skultety
Also enforce the enum type for MigrateSetMaxSpeed and MigrateGetMaxSpeed functions which previously accepted generic uint32 type since the flags haven't been in use. Signed-off-by: Erik Skultety --- domain.go | 10 -- domain_compat.h | 4 2 files changed, 12 insertions(+), 2