Re: [libvirt] [libvirt-python PATCH] override: add virDomainFSFreeze and virDomainFSThaw API

2014-05-13 Thread Daniel P. Berrange
On Mon, May 12, 2014 at 05:12:45PM -0600, Eric Blake wrote: > On 05/12/2014 07:22 AM, Michal Privoznik wrote: > > On 10.05.2014 01:21, Tomoki Sekiyama wrote: > >> Add binding for the new virDomainFSFreeze and virDomainFSThaw functions > >> added in libvirt 1.2.5. These require override since these

Re: [libvirt] [libvirt-python PATCH] override: add virDomainFSFreeze and virDomainFSThaw API

2014-05-12 Thread Eric Blake
On 05/12/2014 07:22 AM, Michal Privoznik wrote: > On 10.05.2014 01:21, Tomoki Sekiyama wrote: >> Add binding for the new virDomainFSFreeze and virDomainFSThaw functions >> added in libvirt 1.2.5. These require override since these take a list >> of mountpoints path string. The methods are named 'fS

Re: [libvirt] [libvirt-python PATCH] override: add virDomainFSFreeze and virDomainFSThaw API

2014-05-12 Thread Tomoki Sekiyama
Thanks for your review, and a lot of fixes :) . Just a comment... >On 10.05.2014 01:21, Tomoki Sekiyama wrote: >diff --git a/libvirt-override.c b/libvirt-override.c >index d0557c2..d08b271 100644 >--- a/libvirt-override.c >+++ b/libvirt-override.c >@@ -7564,7 +7564,7 @@ libvirt_virDomainFSFreeze(

Re: [libvirt] [libvirt-python PATCH] override: add virDomainFSFreeze and virDomainFSThaw API

2014-05-12 Thread Michal Privoznik
On 12.05.2014 17:13, Tomoki Sekiyama wrote: Thanks for your review, and a lot of fixes :) . Just a comment... On 10.05.2014 01:21, Tomoki Sekiyama wrote: diff --git a/libvirt-override.c b/libvirt-override.c index d0557c2..d08b271 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -756

Re: [libvirt] [libvirt-python PATCH] override: add virDomainFSFreeze and virDomainFSThaw API

2014-05-12 Thread Michal Privoznik
On 10.05.2014 01:21, Tomoki Sekiyama wrote: > Add binding for the new virDomainFSFreeze and virDomainFSThaw functions > added in libvirt 1.2.5. These require override since these take a list > of mountpoints path string. The methods are named 'fSFreeze' and 'fSThaw', > like a existing 'fSTrim' meth

[libvirt] [libvirt-python PATCH] override: add virDomainFSFreeze and virDomainFSThaw API

2014-05-09 Thread Tomoki Sekiyama
Add binding for the new virDomainFSFreeze and virDomainFSThaw functions added in libvirt 1.2.5. These require override since these take a list of mountpoints path string. The methods are named 'fSFreeze' and 'fSThaw', like a existing 'fSTrim' method. Signed-off-by: Tomoki Sekiyama --- generator.