Re: [libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

2014-05-06 Thread Eric Blake
On 04/23/2014 04:42 AM, Giuseppe Scrivano wrote: > Some CDROM devices are reported by udev to have an ID_TYPE="generic" > thus it is necessary to check if ID_CDROM is present. > > As a side effect, treating ID_TYPE="generic" as a missing ID_TYPE will > enable checks for ID_DRIVE_FLASH_SD and ID_DR

Re: [libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

2014-05-06 Thread Eric Blake
On 05/06/2014 05:11 AM, Giuseppe Scrivano wrote: > "Daniel P. Berrange" writes: > >> On Wed, Apr 23, 2014 at 12:42:01PM +0200, Giuseppe Scrivano wrote: >>> Some CDROM devices are reported by udev to have an ID_TYPE="generic" >>> thus it is necessary to check if ID_CDROM is present. >>> >>> As a s

Re: [libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

2014-05-06 Thread Giuseppe Scrivano
"Daniel P. Berrange" writes: > On Wed, Apr 23, 2014 at 12:42:01PM +0200, Giuseppe Scrivano wrote: >> Some CDROM devices are reported by udev to have an ID_TYPE="generic" >> thus it is necessary to check if ID_CDROM is present. >> >> As a side effect, treating ID_TYPE="generic" as a missing ID_TY

Re: [libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

2014-04-30 Thread Daniel P. Berrange
On Wed, Apr 23, 2014 at 12:42:01PM +0200, Giuseppe Scrivano wrote: > Some CDROM devices are reported by udev to have an ID_TYPE="generic" > thus it is necessary to check if ID_CDROM is present. > > As a side effect, treating ID_TYPE="generic" as a missing ID_TYPE will > enable checks for ID_DRIVE_

Re: [libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

2014-04-30 Thread Giuseppe Scrivano
Giuseppe Scrivano writes: > Some CDROM devices are reported by udev to have an ID_TYPE="generic" > thus it is necessary to check if ID_CDROM is present. > > As a side effect, treating ID_TYPE="generic" as a missing ID_TYPE will > enable checks for ID_DRIVE_FLASH_SD and ID_DRIVE_FLOPPY and the > u

[libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

2014-04-23 Thread Giuseppe Scrivano
Some CDROM devices are reported by udev to have an ID_TYPE="generic" thus it is necessary to check if ID_CDROM is present. As a side effect, treating ID_TYPE="generic" as a missing ID_TYPE will enable checks for ID_DRIVE_FLASH_SD and ID_DRIVE_FLOPPY and the udevKludgeStorageType heuristic. Signed