[libvirt] [vmware] Fix VMware driver version checking on Linux

2014-01-22 Thread ryan woodsmall
Below works, but it still special cases Fusion. I'm not sure it's better, but I think the VMWARE_DRIVER_FUSION pattern string could be changed to just "VMware Fusion " then tmp checked against "Information:" and discarded if a match is found using the tokenized output of virStringSplit. Something l

[libvirt] [vmware] Fix VMware driver version checking on Linux

2014-01-21 Thread ryan woodsmall
> Daniel Excellent point, Daniel. Try two is below. The verbuf string is tokenized on newline, then iterated over with blank lines ignored. First match of the VMware driver pattern will break out of the loop with tmp set correctly or the default NULL if it's not found. This should allow vmwareExtr

Re: [libvirt] [vmware] Fix VMware driver version checking on Linux

2014-01-21 Thread Daniel P. Berrange
On Mon, Jan 20, 2014 at 02:19:20PM -0600, ryan woodsmall wrote: > Recent changes to the VMware driver allow for VMware Fusion version checking > on OS X. It looks like the version checking on Linux for VMware Workstation > and Player could possibly be broken by the changes. The version check in

[libvirt] [vmware] Fix VMware driver version checking on Linux

2014-01-20 Thread ryan woodsmall
Recent changes to the VMware driver allow for VMware Fusion version checking on OS X. It looks like the version checking on Linux for VMware Workstation and Player could possibly be broken by the changes. The version check in vmware_conf.c bundled STDOUT and STDERR into a common buffer; when/if