Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-10 Thread Laine Stump
On 10/10/2016 05:27 AM, Andrea Bolognani wrote: On Fri, 2016-10-07 at 12:11 -0400, Laine Stump wrote: So instead of guaranteeing that there will always be an empty slot available for hotplug during a single start/destroy cycle of the guest, we would be guaranteeing that there will be 3/4 empty s

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-10 Thread Andrea Bolognani
On Fri, 2016-10-07 at 12:11 -0400, Laine Stump wrote: > > So instead of guaranteeing that there will always be an empty > > slot available for hotplug during a single start/destroy > > cycle of the guest, we would be guaranteeing that there will > > be 3/4 empty slots available for either hotplug o

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-07 Thread Laine Stump
On 10/07/2016 11:16 AM, Andrea Bolognani wrote: On Fri, 2016-10-07 at 10:17 -0400, Laine Stump wrote: So here's a rewording of your description (with a couple additional conditions) to see if I understand everything correctly: 1) during initial domain definition: A) If there are *no pci co

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-07 Thread Andrea Bolognani
On Fri, 2016-10-07 at 10:17 -0400, Laine Stump wrote: > So here's a rewording of your description (with a couple additional  > conditions) to see if I understand everything correctly: >  > 1) during initial domain definition: >  > A) If there are *no pci controllers at all* (not even a pci-root or 

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-07 Thread Laine Stump
On 10/06/2016 12:10 PM, Daniel P. Berrange wrote: On Thu, Oct 06, 2016 at 11:57:17AM -0400, Laine Stump wrote: On 10/06/2016 11:31 AM, Daniel P. Berrange wrote: On Thu, Oct 06, 2016 at 12:58:51PM +0200, Andrea Bolognani wrote: On Wed, 2016-10-05 at 18:36 +0100, Richard W.M. Jones wrote: (b) I

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-06 Thread Laine Stump
On 10/06/2016 11:20 AM, Richard W.M. Jones wrote: On Thu, Oct 06, 2016 at 10:00:39AM -0400, Laine Stump wrote: * x 4 - a set of USB2 controllers. This will turn into a single USB3 controller on a root-port after my patches. Alternately, since it seems you don't use it, you could eliminate it wi

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-06 Thread Andrea Bolognani
On Thu, 2016-10-06 at 11:57 -0400, Laine Stump wrote: > (BTW, isn't there something wrt aarch64 about "no pci controllers in  > config means use mmio for devices", or something like that? (Or maybe we  > were just *thinking* about that and didn't actually do it, I don't  > remember). Using the lack

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2016 at 11:57:17AM -0400, Laine Stump wrote: > On 10/06/2016 11:31 AM, Daniel P. Berrange wrote: > > On Thu, Oct 06, 2016 at 12:58:51PM +0200, Andrea Bolognani wrote: > > > On Wed, 2016-10-05 at 18:36 +0100, Richard W.M. Jones wrote: > > > > > > (b) It would be nice to turn the whol

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-06 Thread Laine Stump
On 10/06/2016 11:31 AM, Daniel P. Berrange wrote: On Thu, Oct 06, 2016 at 12:58:51PM +0200, Andrea Bolognani wrote: On Wed, 2016-10-05 at 18:36 +0100, Richard W.M. Jones wrote: (b) It would be nice to turn the whole thing off for people who don't care about / need hotplugging. I had contempl

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2016 at 12:58:51PM +0200, Andrea Bolognani wrote: > On Wed, 2016-10-05 at 18:36 +0100, Richard W.M. Jones wrote: > > > > (b) It would be nice to turn the whole thing off for people who don't > > > > care about / need hotplugging. > > >  > > > I had contemplated having an "availableP

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-06 Thread Richard W.M. Jones
On Thu, Oct 06, 2016 at 10:00:39AM -0400, Laine Stump wrote: > * x 4 - a set of USB2 > controllers. This will turn into a single USB3 controller on a > root-port after my patches. Alternately, since it seems you don't > use it, you could eliminate it with: Yup, this is auto-added, and a mistake.

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-06 Thread Laine Stump
On 10/06/2016 06:58 AM, Andrea Bolognani wrote: On Wed, 2016-10-05 at 18:36 +0100, Richard W.M. Jones wrote: (b) It would be nice to turn the whole thing off for people who don't care about / need hotplugging. I had contemplated having an "availablePCIeSlots" (or something like that) that wa

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-06 Thread Andrea Bolognani
On Wed, 2016-10-05 at 18:36 +0100, Richard W.M. Jones wrote: > > > (b) It would be nice to turn the whole thing off for people who don't > > > care about / need hotplugging. > >  > > I had contemplated having an "availablePCIeSlots" (or something like > > that) that was either an attribute of the c

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-05 Thread Richard W.M. Jones
On Wed, Oct 05, 2016 at 01:26:31PM -0400, Laine Stump wrote: > On 10/05/2016 11:50 AM, Richard W.M. Jones wrote: > >(b) It would be nice to turn the whole thing off for people who don't > >care about / need hotplugging. > > I had contemplated having an "availablePCIeSlots" (or something like > tha

Re: [libvirt] Analysis of the effect of adding PCIe root ports

2016-10-05 Thread Laine Stump
On 10/05/2016 11:50 AM, Richard W.M. Jones wrote: I was asked to look at the impact on boot times of adding (empty) PCIe root ports to the device model. The proposal from Laine is to add a few of these to every guest to allow hotplugging. Last time I looked into this I found that probing any (l

[libvirt] Analysis of the effect of adding PCIe root ports

2016-10-05 Thread Richard W.M. Jones
I was asked to look at the impact on boot times of adding (empty) PCIe root ports to the device model. The proposal from Laine is to add a few of these to every guest to allow hotplugging. Last time I looked into this I found that probing any (legacy) PCI device is expensive because of the ineffi