Re: [libvirt] BSD gcrypt warnings [was: [PATCH] build: mark conditionally unused variables]

2013-05-13 Thread Roman Bogorodskiy
Eric Blake wrote: > On 05/13/2013 09:46 AM, Eric Blake wrote: > > On 05/11/2013 08:27 AM, Roman Bogorodskiy wrote: > >>> > >>> The sad part is that we aren't even using the deprecated symbols - their > >>> mere inclusion in the installed header is provoking the problems. It > >>> looks like new

Re: [libvirt] BSD gcrypt warnings [was: [PATCH] build: mark conditionally unused variables]

2013-05-13 Thread Eric Blake
On 05/13/2013 09:46 AM, Eric Blake wrote: > On 05/11/2013 08:27 AM, Roman Bogorodskiy wrote: >>> >>> The sad part is that we aren't even using the deprecated symbols - their >>> mere inclusion in the installed header is provoking the problems. It >>> looks like newer gcc is a bit more tolerant (th

Re: [libvirt] BSD gcrypt warnings [was: [PATCH] build: mark conditionally unused variables]

2013-05-13 Thread Eric Blake
On 05/11/2013 08:27 AM, Roman Bogorodskiy wrote: >> >> The sad part is that we aren't even using the deprecated symbols - their >> mere inclusion in the installed header is provoking the problems. It >> looks like newer gcc is a bit more tolerant (that is, this is a >> shortcoming of FreeBSD's use

Re: [libvirt] BSD gcrypt warnings [was: [PATCH] build: mark conditionally unused variables]

2013-05-11 Thread Roman Bogorodskiy
Eric Blake wrote: > On 05/02/2013 09:32 PM, Roman Bogorodskiy wrote: > >>> > >>> Can you actually compile it successfully without '--disable-werror'? > >> > >> Looks like I skipped a few files: > >> > >> $ ./config.status --version | head -n3 > >> libvirt config.status 1.0.5 > >> configured by .

Re: [libvirt] BSD gcrypt warnings [was: [PATCH] build: mark conditionally unused variables]

2013-05-10 Thread Eric Blake
On 05/02/2013 09:32 PM, Roman Bogorodskiy wrote: >>> >>> Can you actually compile it successfully without '--disable-werror'? >> >> Looks like I skipped a few files: >> >> $ ./config.status --version | head -n3 >> libvirt config.status 1.0.5 >> configured by ./configure, generated by GNU Autoconf 2

Re: [libvirt] BSD gcrypt warnings [was: [PATCH] build: mark conditionally unused variables]

2013-05-02 Thread Roman Bogorodskiy
Eric Blake wrote: > On 05/02/2013 06:38 AM, Roman Bogorodskiy wrote: > > Eric Blake wrote: > > > >> These fixes solve a compilation failure on FreeBSD: > >> > >> util/virnetdevtap.c: In function 'virNetDevTapGetName': > >> util/virnetdevtap.c:56: warning: unused parameter 'tapfd' > >> [-Wunu

[libvirt] BSD gcrypt warnings [was: [PATCH] build: mark conditionally unused variables]

2013-05-02 Thread Eric Blake
On 05/02/2013 06:38 AM, Roman Bogorodskiy wrote: > Eric Blake wrote: > >> These fixes solve a compilation failure on FreeBSD: >> >> util/virnetdevtap.c: In function 'virNetDevTapGetName': >> util/virnetdevtap.c:56: warning: unused parameter 'tapfd' >> [-Wunused-parameter] >> util/virnetdevtap.c