Re: [libvirt] PATCH: 12/14: Convert XM driver XML formatter to generic API

2008-07-25 Thread Daniel P. Berrange
On Thu, Jul 24, 2008 at 11:53:48AM -0400, Daniel Veillard wrote: > > > -hvm > > +hvm > > Hum the previous patch was changing things the way around ... > > > > > -/usr/lib/xen/bin/qemu-dm > > > > and removing the extra emulator Yes were indeed both bugs - I'm fixing th

Re: [libvirt] PATCH: 12/14: Convert XM driver XML formatter to generic API

2008-07-24 Thread Daniel Veillard
On Thu, Jul 24, 2008 at 06:03:24PM +0100, Daniel P. Berrange wrote: > On Thu, Jul 24, 2008 at 11:53:48AM -0400, Daniel Veillard wrote: > > On Tue, Jul 08, 2008 at 05:41:01PM +0100, Daniel P. Berrange wrote: > > > This replaces the code which converts from virConfPtr objects > > > into XML, with cod

Re: [libvirt] PATCH: 12/14: Convert XM driver XML formatter to generic API

2008-07-24 Thread Daniel P. Berrange
On Thu, Jul 24, 2008 at 11:53:48AM -0400, Daniel Veillard wrote: > On Tue, Jul 08, 2008 at 05:41:01PM +0100, Daniel P. Berrange wrote: > > This replaces the code which converts from virConfPtr objects > > into XML, with code which converts from virConfPtr objects > > straight into virDomainDefPtr o

Re: [libvirt] PATCH: 12/14: Convert XM driver XML formatter to generic API

2008-07-24 Thread Daniel Veillard
On Tue, Jul 08, 2008 at 05:41:01PM +0100, Daniel P. Berrange wrote: > This replaces the code which converts from virConfPtr objects > into XML, with code which converts from virConfPtr objects > straight into virDomainDefPtr objects. A few more XML changes > are needed in the test suite to take acc

Re: [libvirt] PATCH: 12/14: Convert XM driver XML formatter to generic API

2008-07-08 Thread Daniel P. Berrange
This replaces the code which converts from virConfPtr objects into XML, with code which converts from virConfPtr objects straight into virDomainDefPtr objects. A few more XML changes are needed in the test suite to take account of better XML generation this produces src/xend_internal.c