Re: [libvirt] PATCH: 2/11: Move internal error APIs into virterror_internal.h

2008-10-30 Thread Daniel Veillard
On Thu, Oct 30, 2008 at 02:21:35PM +, Daniel P. Berrange wrote: > On Thu, Oct 30, 2008 at 03:19:11PM +0100, Daniel Veillard wrote: > > On Thu, Oct 30, 2008 at 01:36:10PM +, Daniel P. Berrange wrote: > > > After Daniel's feedback that adding src/virterror.h is confusing, I've > > > re-done t

Re: [libvirt] PATCH: 2/11: Move internal error APIs into virterror_internal.h

2008-10-30 Thread Daniel P. Berrange
On Thu, Oct 30, 2008 at 03:19:11PM +0100, Daniel Veillard wrote: > On Thu, Oct 30, 2008 at 01:36:10PM +, Daniel P. Berrange wrote: > > After Daniel's feedback that adding src/virterror.h is confusing, I've > > re-done the patch to instead add virterror_internal.h, making it clear > > that these

Re: [libvirt] PATCH: 2/11: Move internal error APIs into virterror_internal.h

2008-10-30 Thread Daniel Veillard
On Thu, Oct 30, 2008 at 01:36:10PM +, Daniel P. Berrange wrote: > After Daniel's feedback that adding src/virterror.h is confusing, I've > re-done the patch to instead add virterror_internal.h, making it clear > that these function prototypes are related to virterror.c, but internal > use only.

Re: [libvirt] PATCH: 2/11: Move internal error APIs into virterror_internal.h

2008-10-30 Thread Daniel P. Berrange
After Daniel's feedback that adding src/virterror.h is confusing, I've re-done the patch to instead add virterror_internal.h, making it clear that these function prototypes are related to virterror.c, but internal use only. That patch is basically moving them out of src/internal.h In addition it re