Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-03-10 Thread Pritesh Kothari
Hi All, > If you change this file, you'll also need to change the corresponding > file tests/qemuxml2argvdata/qemuxml2argv-sound.args, which is the > command line ARGV associated with that XML. Should merely need to > add ',ac97' into the appropriate place. Resubmitting the patch with above chang

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-03-10 Thread Daniel P. Berrange
On Tue, Mar 10, 2009 at 11:46:13AM +0100, Pritesh Kothari wrote: > Hi All, > > Small patch for updating the schema file and testcase for the same: > > diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng > index 2e2e408..107215c 100644 > --- a/docs/schemas/domain.rng > +++ b/docs/schema

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-03-10 Thread Pritesh Kothari
Hi All, Small patch for updating the schema file and testcase for the same: diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 2e2e408..107215c 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -874,6 +874,7 @@ sb16 es1370 pcs

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-01-19 Thread Richard W.M. Jones
On Fri, Jan 16, 2009 at 04:59:13PM +0100, Daniel Veillard wrote: > On Tue, Jan 13, 2009 at 05:49:02PM +, Daniel P. Berrange wrote: > > QEMU now has support for a sound card of type "ac97", so enable > > that in the XML parser / qemu driver. > > Not related to the threading really, looks fine

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-01-16 Thread Daniel Veillard
On Tue, Jan 13, 2009 at 05:49:02PM +, Daniel P. Berrange wrote: > QEMU now has support for a sound card of type "ac97", so enable > that in the XML parser / qemu driver. Not related to the threading really, looks fine. Any automatic way to detect unused functions ? I guess we can't expect t

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-01-16 Thread Richard W.M. Jones
On Wed, Jan 14, 2009 at 11:41:32AM +, Daniel P. Berrange wrote: > On Tue, Jan 13, 2009 at 05:49:02PM +, Daniel P. Berrange wrote: > > QEMU now has support for a sound card of type "ac97", so enable > > that in the XML parser / qemu driver. > > > > Also remove some unused cruft relating to

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-01-15 Thread Daniel P. Berrange
On Wed, Jan 14, 2009 at 09:34:51AM -0500, Cole Robinson wrote: > Daniel P. Berrange wrote: > > On Tue, Jan 13, 2009 at 05:49:02PM +, Daniel P. Berrange wrote: > >> QEMU now has support for a sound card of type "ac97", so enable > >> that in the XML parser / qemu driver. > >> > >> Also remove so

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-01-14 Thread Jim Meyering
"Daniel P. Berrange" wrote: > On Tue, Jan 13, 2009 at 05:49:02PM +, Daniel P. Berrange wrote: >> QEMU now has support for a sound card of type "ac97", so enable >> that in the XML parser / qemu driver. >> >> Also remove some unused cruft relating to sound in Xen. >> >> domain_conf.c |3

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-01-14 Thread Cole Robinson
Daniel P. Berrange wrote: > On Tue, Jan 13, 2009 at 05:49:02PM +, Daniel P. Berrange wrote: >> QEMU now has support for a sound card of type "ac97", so enable >> that in the XML parser / qemu driver. >> >> Also remove some unused cruft relating to sound in Xen. >> >> domain_conf.c |3 ++-

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-01-14 Thread Daniel P. Berrange
On Tue, Jan 13, 2009 at 05:49:02PM +, Daniel P. Berrange wrote: > QEMU now has support for a sound card of type "ac97", so enable > that in the XML parser / qemu driver. > > Also remove some unused cruft relating to sound in Xen. > > domain_conf.c |3 ++- > domain_conf.h |1 + >

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-01-13 Thread Daniel P. Berrange
QEMU now has support for a sound card of type "ac97", so enable that in the XML parser / qemu driver. Also remove some unused cruft relating to sound in Xen. domain_conf.c |3 ++- domain_conf.h |1 + xend_internal.c | 46 -- 3 files chang