Re: [libvirt] PATCH: Fix NULL checks in openvz driver

2008-09-08 Thread Daniel Veillard
On Mon, Sep 08, 2008 at 11:51:28AM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > On Fri, Sep 05, 2008 at 05:40:16PM +0200, Jim Meyering wrote: > ... > >> All looks correct. > >> However, I'm a little nervous about hard-coding those '[3]'s. > >> What if someone ins

Re: [libvirt] PATCH: Fix NULL checks in openvz driver

2008-09-08 Thread Daniel P. Berrange
On Mon, Sep 08, 2008 at 04:06:26PM +0400, Evgeniy Sokolov wrote: > >On Fri, Sep 05, 2008 at 05:40:16PM +0200, Jim Meyering wrote: > >>"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > >>>Jim pointed out some places where the openvz driver could deference some > >>>NULs, so this patch fixes them > >

Re: [libvirt] PATCH: Fix NULL checks in openvz driver

2008-09-08 Thread Evgeniy Sokolov
On Fri, Sep 05, 2008 at 05:40:16PM +0200, Jim Meyering wrote: "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: Jim pointed out some places where the openvz driver could deference some NULs, so this patch fixes them ... Index: src/openvz_driver.c =

Re: [libvirt] PATCH: Fix NULL checks in openvz driver

2008-09-08 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Fri, Sep 05, 2008 at 05:40:16PM +0200, Jim Meyering wrote: ... >> All looks correct. >> However, I'm a little nervous about hard-coding those '[3]'s. >> What if someone inserts a new --foo option somewhere before >> the NULL place-holder, or othe

Re: [libvirt] PATCH: Fix NULL checks in openvz driver

2008-09-08 Thread Daniel P. Berrange
On Fri, Sep 05, 2008 at 05:40:16PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > Jim pointed out some places where the openvz driver could deference some > > NULs, so this patch fixes them > ... > > Index: src/openvz_driver.c > > ==

Re: [libvirt] PATCH: Fix NULL checks in openvz driver

2008-09-05 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > Jim pointed out some places where the openvz driver could deference some > NULs, so this patch fixes them ... > Index: src/openvz_driver.c > === > RCS file: /data/cvs/libvirt/src/openvz

[libvirt] PATCH: Fix NULL checks in openvz driver

2008-09-05 Thread Daniel P. Berrange
Jim pointed out some places where the openvz driver could deference some NULs, so this patch fixes them Daniel Index: src/openvz_driver.c === RCS file: /data/cvs/libvirt/src/openvz_driver.c,v retrieving revision 1.46 diff -u -p -r1.