Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-26 Thread Daniel Veillard
On Thu, Jun 26, 2008 at 02:53:44PM +0100, Daniel P. Berrange wrote: > On Thu, Jun 26, 2008 at 09:19:15AM -0400, Daniel Veillard wrote: > > On Tue, Jun 24, 2008 at 04:34:11PM +0100, Daniel P. Berrange wrote: > > > We currently have five drivers which handle the domain XML containing > > > duplicated

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-26 Thread Cole Robinson
Daniel P. Berrange wrote: > > Given an XML document describing a network, parses the doc and generates > a virDomainDefPtr to represent it in memory. This is a little more > advanced than the network parser because the various hypervisor drivers > have slightly varying capabilities. So we pass a

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-26 Thread Daniel P. Berrange
On Thu, Jun 26, 2008 at 09:19:15AM -0400, Daniel Veillard wrote: > On Tue, Jun 24, 2008 at 04:34:11PM +0100, Daniel P. Berrange wrote: > > We currently have five drivers which handle the domain XML containing > > duplicated parsers and formatters for the XML with varying degrees of > > buginess, an

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-26 Thread Daniel Veillard
On Tue, Jun 24, 2008 at 04:34:11PM +0100, Daniel P. Berrange wrote: > We currently have five drivers which handle the domain XML containing > duplicated parsers and formatters for the XML with varying degrees of > buginess, and often very similar structs. This patch introduces a new > general purpo

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-25 Thread Daniel Berrange
On Wed, Jun 25, 2008 at 11:58:10AM +0200, Gerd Hoffmann wrote: > Daniel P. Berrange wrote: > >> IMHO it is a fundamental design flaw that dumpxml gives different > >> results depending on whenever the domain is running or not. Hard to fix > >> by now though :-( > > > > Actually there is another w

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-25 Thread Gerd Hoffmann
Daniel P. Berrange wrote: >> IMHO it is a fundamental design flaw that dumpxml gives different >> results depending on whenever the domain is running or not. Hard to fix >> by now though :-( > > Actually there is another way to access the info - pass the flag > VIR_DOMAIN_XML_INACTIVE to the Dump

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-25 Thread Daniel P. Berrange
On Wed, Jun 25, 2008 at 10:05:30AM +0200, Gerd Hoffmann wrote: > Daniel P. Berrange wrote: > > In the element for VNC we have a 'port' attribute. For a running > > VM this contains the actual port number. For an inactive VM it contains > > the pre-allocated fixed port number, or -1 to indicate tha

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-25 Thread Gerd Hoffmann
Daniel P. Berrange wrote: > In the element for VNC we have a 'port' attribute. For a running > VM this contains the actual port number. For an inactive VM it contains > the pre-allocated fixed port number, or -1 to indicate that a automatically > allocated port should be used. > > There is an obv

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-24 Thread Daniel P. Berrange
On Tue, Jun 24, 2008 at 04:34:11PM +0100, Daniel P. Berrange wrote: > We currently have five drivers which handle the domain XML containing > duplicated parsers and formatters for the XML with varying degrees of > buginess, and often very similar structs. This patch introduces a new > general purpo