Re: [libvirt] PATCH: Misc fixes to qparams

2008-05-22 Thread Daniel P. Berrange
On Thu, May 22, 2008 at 05:51:56PM +0100, Richard W.M. Jones wrote: > On Thu, May 22, 2008 at 12:49:04AM +0100, Daniel P. Berrange wrote: > > - In the qparam_query_parse() method, after appending each (name,value) > >pair of params, it failed to free the temporary buffers for the > >(name

Re: [libvirt] PATCH: Misc fixes to qparams

2008-05-22 Thread Richard W.M. Jones
On Thu, May 22, 2008 at 12:49:04AM +0100, Daniel P. Berrange wrote: > - In the qparam_query_parse() method, after appending each (name,value) >pair of params, it failed to free the temporary buffers for the >(name,value) pair. > - Did not allow for ';' as a valid query parameter separato

Re: [libvirt] PATCH: Misc fixes to qparams

2008-05-22 Thread Daniel P. Berrange
On Thu, May 22, 2008 at 08:57:04AM -0400, Daniel Veillard wrote: > On Thu, May 22, 2008 at 12:49:04AM +0100, Daniel P. Berrange wrote: > > I found a couple more small bugs in the qparams code > > > > - In the qparam_query_parse() method, after appending each (name,value) > >pair of params, it

Re: [libvirt] PATCH: Misc fixes to qparams

2008-05-22 Thread Daniel Veillard
On Thu, May 22, 2008 at 12:49:04AM +0100, Daniel P. Berrange wrote: > I found a couple more small bugs in the qparams code > > - In the qparam_query_parse() method, after appending each (name,value) >pair of params, it failed to free the temporary buffers for the >(name,value) pair. > -

Re: [libvirt] PATCH: Misc fixes to qparams

2008-05-22 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > I found a couple more small bugs in the qparams code > > - In the qparam_query_parse() method, after appending each (name,value) >pair of params, it failed to free the temporary buffers for the >(name,value) pair. > - Did not allow for ';

[libvirt] PATCH: Misc fixes to qparams

2008-05-21 Thread Daniel P. Berrange
I found a couple more small bugs in the qparams code - In the qparam_query_parse() method, after appending each (name,value) pair of params, it failed to free the temporary buffers for the (name,value) pair. - Did not allow for ';' as a valid query parameter separator - In a couple of OO