Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-31 Thread Ryota OZAKI
Hi, I'm happy to use this new feature in my code ;) BTW, > 0744 > 0744 this example code makes me confused because it looks like a mode octal permission set not a numeric ID. I think it's better to use decimal digits something like '500' (ID o

Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-27 Thread Daniel P. Berrange
On Tue, Jan 27, 2009 at 05:59:37PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" wrote: > > On Thu, Jan 22, 2009 at 07:15:19PM +0100, Jim Meyering wrote: > >> "Daniel P. Berrange" wrote: > ... > > Did that, and likewise the similar allocation a little above this chunk > ... > > All looks fi

Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-27 Thread Jim Meyering
"Daniel P. Berrange" wrote: > On Thu, Jan 22, 2009 at 07:15:19PM +0100, Jim Meyering wrote: >> "Daniel P. Berrange" wrote: ... > Did that, and likewise the similar allocation a little above this chunk ... All looks fine. ACK. You'll have noticed that the fix below is already committed. > diff

Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-27 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 07:15:19PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" wrote: > > This is a follow up on Miloslav's proposal to add copy on write > > support to the storage APIs, changing the XML to that described > > here: > > > > http://www.redhat.com/archives/libvir-list/2009-Ja

Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-23 Thread Jim Meyering
Miloslav Trmač wrote: > Jim Meyering píše v Čt 22. 01. 2009 v 19:15 +0100: >> > +static int >> > +cowGetBackingStore(virConnectPtr conn, >> > + char **res, >> > + const unsigned char *buf, >> > + size_t buf_size) >> > +{ >> > +size_t len;

Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-23 Thread Miloslav Trmač
Jim Meyering píše v Čt 22. 01. 2009 v 19:15 +0100: > > +static int > > +cowGetBackingStore(virConnectPtr conn, > > + char **res, > > + const unsigned char *buf, > > + size_t buf_size) > > +{ > > +size_t len; > > + > > +*res = NULL; > > +

Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-22 Thread Jim Meyering
"Daniel P. Berrange" wrote: > This is a follow up on Miloslav's proposal to add copy on write > support to the storage APIs, changing the XML to that described > here: > > http://www.redhat.com/archives/libvir-list/2009-January/msg00231.html > > In addition to the original QCOW/VMDK support, I h

[libvirt] PATCH: Support storage copy on write volumes

2009-01-20 Thread Daniel P. Berrange
This is a follow up on Miloslav's proposal to add copy on write support to the storage APIs, changing the XML to that described here: http://www.redhat.com/archives/libvir-list/2009-January/msg00231.html In addition to the original QCOW/VMDK support, I have done an impl which can extract the b