Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-09-05 Thread Daniel Veillard
On Fri, Sep 05, 2008 at 03:20:32PM +0100, Daniel P. Berrange wrote: > On Fri, Aug 29, 2008 at 12:54:18PM +0400, Evgeniy Sokolov wrote: > > >On Thu, Aug 28, 2008 at 12:06:08PM +0400, Evgeniy Sokolov wrote: > > >>>The biggest flaw I see currently is that the > > >>>openvz driver doesn't load the exis

Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-09-05 Thread Daniel P. Berrange
On Fri, Sep 05, 2008 at 04:31:06PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > >> > static int openvzDomainShutdown(virDomainPtr dom) { > >> > struct openvz_driver *driver = (struct openvz_driver > >> > *)dom->conn->privateData; > >> > -struct openvz_vm

Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-09-05 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >> > static int openvzDomainShutdown(virDomainPtr dom) { >> > struct openvz_driver *driver = (struct openvz_driver >> > *)dom->conn->privateData; >> > -struct openvz_vm *vm = openvzFindVMByUUID(driver, dom->uuid); >> > -const char *prog

Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-09-05 Thread Daniel P. Berrange
On Fri, Aug 29, 2008 at 05:14:12PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > Here's an updated patch > ... > > diff -r e270be59a80f src/openvz_conf.c > ... > > +if (VIR_ALLOC(dom) < 0 || > > +VIR_ALLOC(dom->def) < 0) > > +goto n

Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-09-05 Thread Daniel P. Berrange
On Fri, Aug 29, 2008 at 12:54:18PM +0400, Evgeniy Sokolov wrote: > >On Thu, Aug 28, 2008 at 12:06:08PM +0400, Evgeniy Sokolov wrote: > >>>The biggest flaw I see currently is that the > >>>openvz driver doesn't load the existing device config for networks or > >>>filesystems of existing VMs, so you

Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-09-04 Thread Daniel Veillard
On Thu, Aug 28, 2008 at 09:53:57AM +0100, Daniel P. Berrange wrote: > On Thu, Aug 28, 2008 at 12:06:08PM +0400, Evgeniy Sokolov wrote: > > > The biggest flaw I see currently is that the > > >openvz driver doesn't load the existing device config for networks or > > >filesystems of existing VMs, so y

Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-08-29 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > Here's an updated patch ... > diff -r e270be59a80f src/openvz_conf.c ... > +if (VIR_ALLOC(dom) < 0 || > +VIR_ALLOC(dom->def) < 0) > +goto no_memory; > + > +if (STRNEQ(status, "stopped")) > +dom->st

Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-08-29 Thread Evgeniy Sokolov
On Thu, Aug 28, 2008 at 12:06:08PM +0400, Evgeniy Sokolov wrote: The biggest flaw I see currently is that the openvz driver doesn't load the existing device config for networks or filesystems of existing VMs, so you can't see that info in the XML dump Yes. Good note. I will implement it. -

Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-08-28 Thread Daniel P. Berrange
On Thu, Aug 28, 2008 at 12:06:08PM +0400, Evgeniy Sokolov wrote: > > The biggest flaw I see currently is that the > >openvz driver doesn't load the existing device config for networks or > >filesystems of existing VMs, so you can't see that info in the XML dump > Yes. Good note. I will implement it

Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-08-28 Thread Evgeniy Sokolov
> The biggest flaw I see currently is that the openvz driver doesn't load the existing device config for networks or filesystems of existing VMs, so you can't see that info in the XML dump Yes. Good note. I will implement it. -/*get VCPU*/ -ret = openvzReadConfigParam(veid,

[libvirt] PATCH: Switch openvz driver to domain APIs

2008-08-27 Thread Daniel P. Berrange
This patch is the minimum effort port of the OpenVZ driver over to the new generic domain XML routines. It basically removes all the existing config format stuff from openvz_conf, defines a set of openvz capabilities and implements the DumpXML method too. This is enough to get all the core libvirt