Re: [libvirt] RFC: spec file cleanup ideas

2016-04-15 Thread Andrea Bolognani
On Fri, 2016-04-15 at 06:40 -0400, Cole Robinson wrote: > > On the other hand... Why do we ship the .spec file in the first > > place? Is Fedora, or any other distribution for that matter, > > using it as-is? Or is it meant to be just for developers' > > convenience? > > > > Personally, I'd be hap

Re: [libvirt] RFC: spec file cleanup ideas

2016-04-15 Thread Cole Robinson
On 04/15/2016 07:40 AM, Roman Bogorodskiy wrote: > Cole Robinson wrote: > >> Thanks for the comments >> >> On 04/15/2016 06:14 AM, Daniel P. Berrange wrote: >>> * Drop with_* conditionals that are only used by old Fedora or RHEL5. I didn't audit all of them but the obvious ones a

Re: [libvirt] RFC: spec file cleanup ideas

2016-04-15 Thread Daniel P. Berrange
On Fri, Apr 15, 2016 at 02:40:29PM +0300, Roman Bogorodskiy wrote: > Cole Robinson wrote: > > > Thanks for the comments > > > > On 04/15/2016 06:14 AM, Daniel P. Berrange wrote: > > > > > >> * Drop with_* conditionals that are only used by old Fedora or RHEL5. I > > >> didn't > > >> audit all

Re: [libvirt] RFC: spec file cleanup ideas

2016-04-15 Thread Roman Bogorodskiy
Cole Robinson wrote: > Thanks for the comments > > On 04/15/2016 06:14 AM, Daniel P. Berrange wrote: > > > >> * Drop with_* conditionals that are only used by old Fedora or RHEL5. I > >> didn't > >> audit all of them but the obvious ones are straight forward like: > >> with_systemd_macros, wi

Re: [libvirt] RFC: spec file cleanup ideas

2016-04-15 Thread Cole Robinson
On 04/15/2016 06:03 AM, Andrea Bolognani wrote: > On Fri, 2016-04-08 at 19:13 -0400, Cole Robinson wrote: >> Hi all, >> >> I wanted to float some ideas about cleaning up the RPM spec file. None of it >> is urgent but I'll end up scratching the itch eventually and I want to make >> sure people are

Re: [libvirt] RFC: spec file cleanup ideas

2016-04-15 Thread Cole Robinson
Thanks for the comments On 04/15/2016 06:14 AM, Daniel P. Berrange wrote: > >> * Drop with_* conditionals that are only used by old Fedora or RHEL5. I >> didn't >> audit all of them but the obvious ones are straight forward like: >> with_systemd_macros, with_polkit, with_capng, with_netcf, with_

Re: [libvirt] RFC: spec file cleanup ideas

2016-04-15 Thread Daniel P. Berrange
On Fri, Apr 08, 2016 at 07:13:07PM -0400, Cole Robinson wrote: > Hi all, > > I wanted to float some ideas about cleaning up the RPM spec file. None of it > is urgent but I'll end up scratching the itch eventually and I want to make > sure people are on board > > Old distro bits: > > * Drop suppo

Re: [libvirt] RFC: spec file cleanup ideas

2016-04-15 Thread Andrea Bolognani
On Fri, 2016-04-08 at 19:13 -0400, Cole Robinson wrote: > Hi all, >  > I wanted to float some ideas about cleaning up the RPM spec file. None of it > is urgent but I'll end up scratching the itch eventually and I want to make > sure people are on board So I actually just skimmed your proposal... I

[libvirt] RFC: spec file cleanup ideas

2016-04-08 Thread Cole Robinson
Hi all, I wanted to float some ideas about cleaning up the RPM spec file. None of it is urgent but I'll end up scratching the itch eventually and I want to make sure people are on board Old distro bits: * Drop support for building on rhel5... this was ACKd previously by eblake: http://www.redhat