Re: [libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

2008-08-28 Thread Richard W.M. Jones
On Wed, Aug 27, 2008 at 09:20:18PM +, David Lutterkort wrote: > On Wed, 2008-08-27 at 12:03 +0100, Richard W.M. Jones wrote: > > Out of interest, do you ever hit the 16 bit limit in the size of > > compiled regexps? The "bytecode" used to represent compiled GNU > > regexps has (or perhaps had)

[libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

2008-08-27 Thread David Lutterkort
On Wed, 2008-08-27 at 12:31 +0100, Daniel P. Berrange wrote: > On Tue, Aug 26, 2008 at 09:40:41PM +, David Lutterkort wrote: > > On Tue, 2008-08-26 at 21:05 +0100, Daniel P. Berrange wrote: > > > > > + let empty = [ label "empty" . del /[ \t]*\n/ "" ] > > > > Do you really care that empty e

Re: [libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

2008-08-27 Thread David Lutterkort
On Wed, 2008-08-27 at 12:15 +0100, Richard W.M. Jones wrote: > Dan pointed out that you have your own DFA implementation. Actually, libf does everything but matching - it does all the regexp calculations needed for the typechecker; for matching, I use GNU regex. David -- Libvir-list mailing lis

Re: [libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

2008-08-27 Thread David Lutterkort
On Wed, 2008-08-27 at 12:03 +0100, Richard W.M. Jones wrote: > Out of interest, do you ever hit the 16 bit limit in the size of > compiled regexps? The "bytecode" used to represent compiled GNU > regexps has (or perhaps had) a 16 bit limit in the jump offsets, which > I hit a few years back. Had

[libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

2008-08-27 Thread Daniel P. Berrange
On Tue, Aug 26, 2008 at 09:40:41PM +, David Lutterkort wrote: > On Tue, 2008-08-26 at 21:05 +0100, Daniel P. Berrange wrote: > > diff -u -p -r1.51 Makefile.am > > --- qemud/Makefile.am 20 Aug 2008 20:48:35 - 1.51 > > +++ qemud/Makefile.am 26 Aug 2008 20:03:48 - > > @@ -

Re: [libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

2008-08-27 Thread Richard W.M. Jones
Dan pointed out that you have your own DFA implementation. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.re

Re: [libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

2008-08-27 Thread Richard W.M. Jones
On Tue, Aug 26, 2008 at 09:46:22PM +, David Lutterkort wrote: > On Tue, 2008-08-26 at 22:01 +0100, Daniel P. Berrange wrote: > > > While I can see why it is useful to gather these entries logically, it's > > > not > > > very optimised for the parser. Eventually, all this will be compiled into

[libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

2008-08-26 Thread David Lutterkort
On Tue, 2008-08-26 at 22:01 +0100, Daniel P. Berrange wrote: > > While I can see why it is useful to gather these entries logically, it's not > > very optimised for the parser. Eventually, all this will be compiled into a > > huge regexp, so it's more efficient to regroup entries by type and feed t

[libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

2008-08-26 Thread David Lutterkort
On Tue, 2008-08-26 at 22:37 +0200, Raphaƫl Pinson wrote: > Hi Daniel, > > On Tue, Aug 26, 2008 at 10:05 PM, Daniel P. Berrange > <[EMAIL PROTECTED]> wrote: > THis patch is intended to be committed to libvirt, so the > config file rules > are distributed alongside libvirt. I

[libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

2008-08-26 Thread David Lutterkort
On Tue, 2008-08-26 at 21:05 +0100, Daniel P. Berrange wrote: > Now instead of telling people > > 'edit /etc/libvirt/libvirtd.conf and change listen_tls to 1, >and auth_tls to sasl' > > we can say run > ># augtool set /files/e

[libvirt] Re: [augeas-devel] PATCH: Add a augeas lens for libvirtd.conf

2008-08-26 Thread Daniel P. Berrange
On Tue, Aug 26, 2008 at 10:37:02PM +0200, Rapha?l Pinson wrote: > On Tue, Aug 26, 2008 at 10:05 PM, Daniel P. Berrange <[EMAIL PROTECTED]>wrote: > > THis patch is intended to be committed to libvirt, so the config file rules > > are distributed alongside libvirt. I'm CC'ing augeas-devel for feedbac