Re: [libvirt] Remove bashisms from libvirt-guests

2011-01-04 Thread Eric Blake
On 01/04/2011 04:50 PM, Laurent Léonard wrote: >> Here's what I'm planning on squashing in. However, I still have one >> nagging problem, that I haven't been able to figure out yet - even >> though we listed libvirt-guests.init.in in po/POTFILES.in, xgettext >> doesn't seem to be picking it up int

Re: [libvirt] Remove bashisms from libvirt-guests

2011-01-04 Thread Eric Blake
On 01/04/2011 11:13 AM, Laurent Léonard wrote: > > The attached patch should match with your comments. > > Thank you, Thank you for the work. > +++ b/tools/Makefile.am > @@ -146,6 +146,9 @@ BUILT_SOURCES += libvirt-guests.init > > libvirt-guests.init: libvirt-guests.init.in $(top_builddir)/c

Re: [libvirt] Remove bashisms from libvirt-guests

2011-01-03 Thread Eric Blake
On 12/25/2010 12:44 PM, Laurent Léonard wrote: > Le lundi 20 décembre 2010 17:01:14, Eric Blake a écrit : >> On 12/18/2010 04:51 AM, Laurent Léonard wrote: > -retval wait $virsh_pid && printf '\r%s%-12s\n' "$label" $"done" > +retval wait $virsh_pid && printf '\r%s%-12s\n' "$label" "

Re: [libvirt] Remove bashisms from libvirt-guests

2010-12-20 Thread Eric Blake
On 12/18/2010 04:51 AM, Laurent Léonard wrote: >>> >>> -retval wait $virsh_pid && printf '\r%s%-12s\n' "$label" $"done" >>> +retval wait $virsh_pid && printf '\r%s%-12s\n' "$label" "`gettext >>> \"done\"`" >> >> Likewise: "$(gettext "done")" >> >> But thanks for taking this on; we're gettin

Re: [libvirt] Remove bashisms from libvirt-guests

2010-12-17 Thread Eric Blake
On 12/17/2010 04:09 AM, Laurent Léonard wrote: > Hi, > > The attached patch removes bashisms from libvirt-guests. > > TEXTDOMAINDIR is not specified, so system default will be used > ("/usr/share/locale" on Debian, I don't know if it's the same on Fedora). Hmm; that should be derived from one o