Re: [libvirt] build: fix linking virt-login-shell

2013-10-23 Thread Claudio Bley
At Wed, 23 Oct 2013 10:51:29 +0100, Eric Blake wrote: > > > BTW, what's the policy of pushing to maint branches? I remember that > > there was a message on this list regarding permissions on those > > branches, but can't find it right now. Is it prohibited / uncalled for > > to push to those branc

Re: [libvirt] build: fix linking virt-login-shell

2013-10-23 Thread Eric Blake
On 10/23/2013 10:45 AM, Claudio Bley wrote: > At Wed, 23 Oct 2013 09:57:40 +0100, > Michal Privoznik wrote: >> >> On 23.10.2013 07:17, Claudio Bley wrote: >>> Could someone cherrypick this to the maint branches as well, please?! >>> >>> And, while at it, maybe also e350826c6 and 843bdb2f8a3. >> >>

Re: [libvirt] build: fix linking virt-login-shell

2013-10-23 Thread Claudio Bley
At Wed, 23 Oct 2013 09:57:40 +0100, Michal Privoznik wrote: > > On 23.10.2013 07:17, Claudio Bley wrote: > > Could someone cherrypick this to the maint branches as well, please?! > > > > And, while at it, maybe also e350826c6 and 843bdb2f8a3. > > I've backported all three patches onto v1.1.3-mai

Re: [libvirt] build: fix linking virt-login-shell

2013-10-23 Thread Michal Privoznik
On 23.10.2013 07:17, Claudio Bley wrote: > At Tue, 22 Oct 2013 16:27:02 +0100, > Michal Privoznik wrote: >> >> On 22.10.2013 09:29, Daniel P. Berrange wrote: >>> On Mon, Oct 21, 2013 at 03:36:11PM -0600, Jim Fehlig wrote: >From a0f35945f3127ab70d051101037e821b1759b4bb Mon Sep 17 00:00:00 2001

Re: [libvirt] build: fix linking virt-login-shell

2013-10-22 Thread Claudio Bley
At Tue, 22 Oct 2013 16:27:02 +0100, Michal Privoznik wrote: > > On 22.10.2013 09:29, Daniel P. Berrange wrote: > > On Mon, Oct 21, 2013 at 03:36:11PM -0600, Jim Fehlig wrote: > >> >From a0f35945f3127ab70d051101037e821b1759b4bb Mon Sep 17 00:00:00 2001 > >> From: Jim Fehlig > >> Date: Mon, 21 Oct

Re: [libvirt] build: fix linking virt-login-shell

2013-10-22 Thread Michal Privoznik
On 22.10.2013 09:29, Daniel P. Berrange wrote: > On Mon, Oct 21, 2013 at 03:36:11PM -0600, Jim Fehlig wrote: >> >From a0f35945f3127ab70d051101037e821b1759b4bb Mon Sep 17 00:00:00 2001 >> From: Jim Fehlig >> Date: Mon, 21 Oct 2013 15:30:02 -0600 >> Subject: [PATCH] build: fix virt-login-shell build

Re: [libvirt] build: fix linking virt-login-shell

2013-10-22 Thread Daniel P. Berrange
On Mon, Oct 21, 2013 at 03:36:11PM -0600, Jim Fehlig wrote: > >From a0f35945f3127ab70d051101037e821b1759b4bb Mon Sep 17 00:00:00 2001 > From: Jim Fehlig > Date: Mon, 21 Oct 2013 15:30:02 -0600 > Subject: [PATCH] build: fix virt-login-shell build with apparmor > > With libapparmor-devel installed,

[libvirt] build: fix linking virt-login-shell

2013-10-21 Thread Jim Fehlig
After commit 3e2f27e1, I've noticed build failures of virt-login-shell when libapparmor-devel is installed on the build host CCLD virt-login-shell ../src/.libs/libvirt-setuid-rpc-client.a(libvirt_setuid_rpc_client_la-vircommand.o): In function `virExec': /home/jfehlig/virt/upstream/libvirt/src