On 02/10/2011 08:01 AM, Zdenek Styblik wrote:
[...]
Actually, I think these would be _("[<%s>]") (note the<> to signify the
meta-syntactic term). But I like the idea; this shortens the synopsis
form, while still leaving the usage form to explain the meta-syntactic
term.
Right, because '--%s' i
On 02/09/2011 07:26 PM, Eric Blake wrote:
[...]
attach-disk []
When understood, it's ok. And the majority of virsh commands have this
format; except 19; I would stick with it.
I also like the shorter form.
Fine :o) I don't mind either of those.
0001-Unify-virsh-help-synopsis-output
On 02/06/2011 02:29 AM, Zdenek Styblik wrote:
> I didn't say we should take one way or another; neither I've said I'm
> going to. I merely wanted to point out at differences, which I think,
> create a bit of confusion.
>
> As suggested in my hasty reply, perhaps we should have a vote or poll.
> It
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Heya,
I've a bit of re-shuffled original e-mail and for that I'm sorry.
On 02/03/11 19:05, Eric Blake wrote:
> In this case, patches speak louder than words :)
Patch is attached.
> While I agree that a patch to make things more consistent is proba
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/03/11 19:05, Eric Blake wrote:
[...]
>
> While I agree that a patch to make things more consistent is probably
> worthwhile, I was unclear from your report on which way you thought
> things should be changed. In this case, patches speak louder
On 02/03/2011 02:31 AM, Zdenek Styblik wrote:
> Hello,
>
> I've found virsh help output to be inconsistent.
>
> ~~~ SNIP ~~~
> attach-disk[--driver ]...
>
> X
>
> attach-interface[] ...
> ~~~ SNIP ~~~
>
> where is usually explained in OPTIONS as:
> ~~~ SNIP ~~~
> [--domain] domain n
On 02/03/2011 10:44 AM, Justin Clift wrote:
Yeah, consistency would definitely be good, and you're right, it
probably would be just a matter of modifying printf() types of
statements.
You're definitely welcome to create patches to accomplish this if you
want. :)
+ Justin
Good.
Thanks,
Z.
-
On 03/02/2011, at 8:31 PM, Zdenek Styblik wrote:
> Hello,
>
> I've found virsh help output to be inconsistent.
>
> ~~~ SNIP ~~~
> attach-disk[--driver ]...
>
> X
>
> attach-interface[] ...
> ~~~ SNIP ~~~
>
> where is usually explained in OPTIONS as:
> ~~~ SNIP ~~~
> [--domain] domai
Hello,
I've found virsh help output to be inconsistent.
~~~ SNIP ~~~
attach-disk[--driver ]...
X
attach-interface[] ...
~~~ SNIP ~~~
where is usually explained in OPTIONS as:
~~~ SNIP ~~~
[--domain] domain name, id or uuid
~~~ SNIP ~~~
Substitution of -> [--domain] resp. that yo