Re: [libvirt-jenkins-ci PATCH v2 6/6] guests: lcitool: Enable the new 'gitlab' flavor in the lcitool script

2020-04-08 Thread Andrea Bolognani
On Wed, 2020-04-08 at 12:42 +0200, Erik Skultety wrote: > On Wed, Apr 08, 2020 at 11:49:45AM +0200, Andrea Bolognani wrote: > > On Tue, 2020-04-07 at 13:31 +0200, Erik Skultety wrote: > > > -extra_vars = json.dumps({ > > > +extra_vars_d = { > > > > You don't really need to change t

Re: [libvirt-jenkins-ci PATCH v2 6/6] guests: lcitool: Enable the new 'gitlab' flavor in the lcitool script

2020-04-08 Thread Erik Skultety
On Wed, Apr 08, 2020 at 11:49:45AM +0200, Andrea Bolognani wrote: > On Tue, 2020-04-07 at 13:31 +0200, Erik Skultety wrote: > > # The vault password is only needed for the jenkins flavor, but in > > # that case we want to make sure there's *something* in there > > -if self

Re: [libvirt-jenkins-ci PATCH v2 6/6] guests: lcitool: Enable the new 'gitlab' flavor in the lcitool script

2020-04-08 Thread Andrea Bolognani
On Tue, 2020-04-07 at 13:31 +0200, Erik Skultety wrote: > # The vault password is only needed for the jenkins flavor, but in > # that case we want to make sure there's *something* in there > -if self.get_flavor() != "test": > +if self.get_flavor() == "jenkins": >

[libvirt-jenkins-ci PATCH v2 6/6] guests: lcitool: Enable the new 'gitlab' flavor in the lcitool script

2020-04-07 Thread Erik Skultety
Signed-off-by: Erik Skultety --- guests/lcitool | 50 +- 1 file changed, 45 insertions(+), 5 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 689a8cf..d9b2372 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -175,7 +175,7 @@ class