Re: [libvirt PATCH] check for NULL before calling g_regex_unref

2020-09-08 Thread Martin Kletzander
On Tue, Sep 08, 2020 at 03:20:52PM +0200, Ján Tomko wrote: g_regex_unref reports an error if called with a NULL argument. We have two cases in the code where we (possibly) call it on a NULL argument. The interesting one is in virDomainQemuMonitorEventCleanup. Based on VIR_CONNECT_DOMAIN_QEMU_MO

Re: [libvirt PATCH] check for NULL before calling g_regex_unref

2020-09-08 Thread Peter Krempa
On Tue, Sep 08, 2020 at 15:20:52 +0200, Ján Tomko wrote: > g_regex_unref reports an error if called with a NULL argument. > > We have two cases in the code where we (possibly) call it on a NULL > argument. The interesting one is in virDomainQemuMonitorEventCleanup. > > Based on VIR_CONNECT_DOMAI

[libvirt PATCH] check for NULL before calling g_regex_unref

2020-09-08 Thread Ján Tomko
g_regex_unref reports an error if called with a NULL argument. We have two cases in the code where we (possibly) call it on a NULL argument. The interesting one is in virDomainQemuMonitorEventCleanup. Based on VIR_CONNECT_DOMAIN_QEMU_MONITOR_EVENT_REGISTER_REGEX, we unref data->regex, which has t